NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit39ae0ef

committed

Fix EXPLAIN of SEARCH BREADTH FIRST queries some more.

Commit3f50b82 had an oversight: formerly, to deparse expressionsattached to a plan node, it was only necessary to update thedeparse_namespace ancestors list alongside calling set_deparse_plan.Now it's necessary to update the ancestors list *first*, becauseset_deparse_plan consults it, and one call site got that wrong.This error was masked in most cases because explain.c uses just oneList object for the ancestors list, updating it in-place as the planis scanned, so that we accidentally had the right List assigned todpns->ancestors before it was needed. It would fail only if aWorkTableScan node were the first one that we tried to deparse asubexpression of.Per report from Markus Winand. Like the previous patch,back-patch to v14.Discussion:https://postgr.es/m/648B0505-AA57-42C2-A2DA-E551DE46FA15@winand.at

1 parent68f7c4b commit39ae0efCopy full SHA for 39ae0ef

File tree

1 file changed

-2

lines changed

src/backend/utils/adt
- ruleutils.c

1 file changed

-2

lines changed

`‎src/backend/utils/adt/ruleutils.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -3681,8 +3681,8 @@ set_deparse_context_plan(List dpcontext, Plan plan, List *ancestors)`
`3681`	`3681`	`dpns= (deparse_namespace*)linitial(dpcontext);`
`3682`	`3682`
`3683`	`3683`	`/* Set our attention on the specific plan node passed in */`
`3684`		`-set_deparse_plan(dpns,plan);`
`3685`	`3684`	`dpns->ancestors=ancestors;`
	`3685`	`+set_deparse_plan(dpns,plan);`
`3686`	`3686`
`3687`	`3687`	`returndpcontext;`
`3688`	`3688`	`}`
`@@ -4836,7 +4836,7 @@ get_rtable_name(int rtindex, deparse_context *context)`
`4836`	`4836`	`* of a given Plan node`
`4837`	`4837`	`*`
`4838`	`4838`	`* This sets the plan, outer_plan, inner_plan, outer_tlist, inner_tlist,`
`4839`		`- * and index_tlist fields. Calleris responsible for adjusting the ancestors`
	`4839`	`+ * and index_tlist fields. Callermust already have adjusted the ancestors`
`4840`	`4840`	`* list if necessary. Note that the rtable, subplans, and ctes fields do`
`4841`	`4841`	`* not need to change when shifting attention to different plan nodes in a`
`4842`	`4842`	`* single plan tree.`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit39ae0ef

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/ruleutils.c`

0 commit comments