Commit39a3bdc

Etsuro Fujita

committed

postgres_fdw: Remove useless if-test in GetConnection().

Checking whether entry->conn is NULL after doing disconnect_pg_server()for that entry is pointless, as that function ensures that it is NULL.Thinko in commit7fc1a81; this would be harmless, so patch HEAD only.Reviewed-by: Richard Guo and Daniel GustafssonDiscussion:https://postgr.es/m/CAPmGK169vQ83PQwQkoxO-AK2EeK1EsgsxixedM%2BBLWEAhZ_AqQ%40mail.gmail.com

1 parentbfc9497 commit39a3bdcCopy full SHA for 39a3bdc

File tree

-2

lines changed

-2

lines changed

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -271,8 +271,7 @@ GetConnection(UserMapping user, bool will_prep_stmt, PgFdwConnState *state)`
`271`	`271`	`entry->conn);`
`272`	`272`	`disconnect_pg_server(entry);`
`273`	`273`
`274`		`-if (entry->conn==NULL)`
`275`		`-make_new_connection(entry,user);`
	`274`	`+make_new_connection(entry,user);`
`276`	`275`
`277`	`276`	`begin_remote_xact(entry);`
`278`	`277`	`}`

Comments

(0)