Commit39a138f

committed

Revert "Fix comments in instr_time.h and remove an unneeded cast to int64"

This reverts commit3dcb09d. Tom Lane pointed out that it broke theabstraction provided by the macros. The callers should not need toknow what the internal type is.This commit is an exact revert, the next commit will fix the commentson the macros that incorrectly claim that they return uint64.Discussion:https://www.postgresql.org/message-id/ZrHkv3MAQfwNSmTG@ip-10-97-1-34.eu-west-3.compute.internal

1 parent6e086fa commit39a138fCopy full SHA for 39a138f

File tree

-3

lines changed

-3

lines changed

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -32,9 +32,9 @@`
`32`	`32`	`*`
`33`	`33`	`* INSTR_TIME_GET_MILLISEC(t)convert t to double (in milliseconds)`
`34`	`34`	`*`
`35`		`- * INSTR_TIME_GET_MICROSEC(t)get t in microseconds`
	`35`	`+ * INSTR_TIME_GET_MICROSEC(t)convert tto uint64 (in microseconds)`
`36`	`36`	`*`
`37`		`- * INSTR_TIME_GET_NANOSEC(t)get t in nanoseconds`
	`37`	`+ * INSTR_TIME_GET_NANOSEC(t)convert tto uint64 (in nanoseconds)`
`38`	`38`	`*`
`39`	`39`	`* Note that INSTR_TIME_SUBTRACT and INSTR_TIME_ACCUM_DIFF convert`
`40`	`40`	`* absolute times to intervals. The INSTR_TIME_GET_xxx operations are`
`@@ -123,7 +123,7 @@ pg_clock_gettime_ns(void)`
`123`	`123`	`((t) = pg_clock_gettime_ns())`
`124`	`124`
`125`	`125`	`#defineINSTR_TIME_GET_NANOSEC(t) \`
`126`		`-((t).ticks)`
	`126`	`+((int64) (t).ticks)`
`127`	`127`
`128`	`128`
`129`	`129`	`#else/* WIN32 */`

Comments

(0)