NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit397cd0b

Amit Kapila

committed

Remove redundant fetch of the recent flush pointer in WalSndWaitForWal.

In WalSndWaitForWal(), we fetch a recent flush pointer both outside theloop and inside the loop. But we start using RecentFlushPtr only after wefetch it inside the loop. So we can remove one outside the loop.Author: Shveta MalikReviewed-by: Bertrand Drouvot, Matthias van de Meent, Amit KapilaDiscussion:https://postgr.es/m/CAJpy0uBSCQz1yMD-WiEthzEe23dti2-Kr_pitVb7vAPFbFKm=A@mail.gmail.com

1 parent2c8118e commit397cd0bCopy full SHA for 397cd0b

File tree

1 file changed

-6

lines changed

src/backend/replication
- walsender.c

1 file changed

-6

lines changed

`‎src/backend/replication/walsender.c‎`

Lines changed: 0 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -1831,12 +1831,6 @@ WalSndWaitForWal(XLogRecPtr loc)`
`1831`	`1831`	`!NeedToWaitForWal(loc,RecentFlushPtr,&wait_event))`
`1832`	`1832`	`returnRecentFlushPtr;`
`1833`	`1833`
`1834`		`-/* Get a more recent flush pointer. */`
`1835`		`-if (!RecoveryInProgress())`
`1836`		`-RecentFlushPtr=GetFlushRecPtr(NULL);`
`1837`		`-else`
`1838`		`-RecentFlushPtr=GetXLogReplayRecPtr(NULL);`
`1839`		`-`
`1840`	`1834`	`/*`
`1841`	`1835`	`* Within the loop, we wait for the necessary WALs to be flushed to disk`
`1842`	`1836`	`* first, followed by waiting for standbys to catch up if there are enough`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit397cd0b

File tree

1 file changed

1 file changed

`‎src/backend/replication/walsender.c‎`

0 commit comments