Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit39428be

Browse files
committed
In jsonb_plpython.c, suppress warning message from gcc 10.
Very recent gcc complains that PLyObject_ToJsonbValue could returna pointer to a local variable. I think it's wrong; but the codingis fragile enough, and the savings of one palloc() minimal enough,that it seems better to just do a palloc() all the time. (My otheridea of tweaking the if-condition doesn't suppress the warning.)Back-patch to v11 where this code was introduced.Discussion:https://postgr.es/m/21547.1580170366@sss.pgh.pa.us
1 parent2c56b3a commit39428be

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

‎contrib/jsonb_plpython/jsonb_plpython.c

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -367,7 +367,6 @@ PLyNumber_ToJsonbValue(PyObject *obj, JsonbValue *jbvNum)
367367
staticJsonbValue*
368368
PLyObject_ToJsonbValue(PyObject*obj,JsonbParseState**jsonb_state,boolis_elem)
369369
{
370-
JsonbValuebuf;
371370
JsonbValue*out;
372371

373372
if (!(PyString_Check(obj)||PyUnicode_Check(obj)))
@@ -378,11 +377,7 @@ PLyObject_ToJsonbValue(PyObject *obj, JsonbParseState **jsonb_state, bool is_ele
378377
returnPLyMapping_ToJsonbValue(obj,jsonb_state);
379378
}
380379

381-
/* Allocate JsonbValue in heap only if it is raw scalar value. */
382-
if (*jsonb_state)
383-
out=&buf;
384-
else
385-
out=palloc(sizeof(JsonbValue));
380+
out=palloc(sizeof(JsonbValue));
386381

387382
if (obj==Py_None)
388383
out->type=jbvNull;

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp