NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit393e828

committed

Avoid potential relcache leak in objectaddress.c.

Nobody using the missing_ok flag yet, but let's speculate that this willbe a better interface for future callers.KaiGai Kohei, with some adjustments by me.

1 parentad30d36 commit393e828Copy full SHA for 393e828

File tree

1 file changed

+10

-1

lines changed

src/backend/catalog
- objectaddress.c

1 file changed

+10

-1

lines changed

`‎src/backend/catalog/objectaddress.c`

Lines changed: 10 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -639,7 +639,8 @@ get_object_address_relobject(ObjectType objtype, List *objname,`
`639`	`639`	`* Caller is expecting to get back the relation, even though we`
`640`	`640`	`* didn't end up using it to find the rule.`
`641`	`641`	`*/`
`642`		`-relation=heap_open(reloid,AccessShareLock);`
	`642`	`+if (OidIsValid(address.objectId))`
	`643`	`+relation=heap_open(reloid,AccessShareLock);`
`643`	`644`	`}`
`644`	`645`	`else`
`645`	`646`	`{`
`@@ -677,6 +678,14 @@ get_object_address_relobject(ObjectType objtype, List *objname,`
`677`	`678`	`address.objectId=InvalidOid;`
`678`	`679`	`address.objectSubId=0;`
`679`	`680`	`}`
	`681`	`+`
	`682`	`+/* Avoid relcache leak when object not found. */`
	`683`	`+if (!OidIsValid(address.objectId))`
	`684`	`+{`
	`685`	`+heap_close(relation,AccessShareLock);`
	`686`	`+relation=NULL;/* department of accident prevention */`
	`687`	`+returnaddress;`
	`688`	`+}`
`680`	`689`	`}`
`681`	`690`
`682`	`691`	`/* Done. */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit393e828

File tree

1 file changed

1 file changed

`‎src/backend/catalog/objectaddress.c`

0 commit comments