Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit38dbaaf

Browse files
author
Amit Kapila
committed
Fix executing invalidation messages generated by subtransactions during decoding.
This problem has been introduced by commit272248a where we startedassigning the subtransactions to the top-level transaction when we markboth the top-level transaction and its subtransactions as containingcatalog changes. After we assign subtransactions to the top-leveltransaction, we were not allowed to execute any invalidations associatedwith it when we decide to skip the transaction.The reason to assign the subtransactions to the top-level transaction wasto avoid the assertion failure in AssertTXNLsnOrder() as they have thesame LSN when we sometimes start accumulating transaction changes forpartial transactions after the restart. Now that with commit64ff0fe,we skip this assertion check until we reach the LSN at which we startdecoding the contents of the transaction, so, there is no reason for suchan assignment anymore.The assignment change was introduced in 15 and prior versions but this bugdoesn't exist in branches prior to 14 since we don't add invalidationmessages to subtransactions. We decided to backpatch through 11 forconsistency but not for 10 since its final release is near.Reported-by: Kuroda HayatoAuthor: Masahiko SawadaReviewed-by: Amit KapilaBackpatch-through: 11Discussion:https://postgr.es/m/TYAPR01MB58660803BCAA7849C8584AA4F57E9%40TYAPR01MB5866.jpnprd01.prod.outlook.comDiscussion:https://postgr.es/m/a89b46b6-0239-2fd5-71a9-b19b1f7a7145%40enterprisedb.com
1 parent25f7be1 commit38dbaaf

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

‎src/backend/replication/logical/snapbuild.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2146,9 +2146,6 @@ SnapBuildXidSetCatalogChanges(SnapBuild *builder, TransactionId xid, int subxcnt
21462146
sizeof(TransactionId),xidComparator)!=NULL)
21472147
{
21482148
for (inti=0;i<subxcnt;i++)
2149-
{
2150-
ReorderBufferAssignChild(builder->reorder,xid,subxacts[i],lsn);
21512149
ReorderBufferXidSetCatalogChanges(builder->reorder,subxacts[i],lsn);
2152-
}
21532150
}
21542151
}

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp