forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit385d396
committed
Split up a couple of long-running regression test scripts.
The point of this change is to increase the potential for parallelismwhile running the core regression tests. Most people these days areusing parallel testing modes on multi-core machines, so we might aswell try a bit harder to keep multiple cores busy. Hence, a test thatruns much longer than others in its parallel group is a candidate tobe sub-divided.In this patch, create_index.sql and join.sql are split up.I haven't changed the content of the tests in any way, justmoved them.I moved create_index.sql's SP-GiST-related tests into a new scriptcreate_index_spgist, and moved its btree multilevel page deletion testover to the existing script btree_index. (btree_index is a more naturalhome for that test, and it's shorter than others in its parallel group,so this doesn't hurt total runtime of that group.) There might beroom for more aggressive splitting of create_index, but this is enoughto improve matters considerably.Likewise, I moved join.sql's "exercises for the hash join code" intoa new file join_hash. Those exercises contributed three-quarters ofthe script's runtime. Which might well be excessive ... but for themoment, I'm satisfied with shoving them into a different parallelgroup, where they can share runtime with the roughly-equally-lengthygist test.(Note for anybody following along at home: there are interestinginteractions between the runtimes of create_index and anything runningin parallel with it, because the tests of CREATE INDEX CONCURRENTLYin that file will repeatedly block waiting for concurrent transactionsto commit. As committed in this patch, create_index andcreate_index_spgist have roughly equal runtimes, but that's mostly anartifact of forced synchronization of the CONCURRENTLY tests; when runserially, create_index is much faster. A followup patch will reducethe runtime of create_index_spgist and thereby also create_index.)Discussion:https://postgr.es/m/735.1554935715@sss.pgh.pa.us1 parent6726d8d commit385d396
File tree
13 files changed
+3353
-3319
lines changed- src/test/regress
- expected
- sql
13 files changed
+3353
-3319
lines changedLines changed: 18 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
244 | 244 |
| |
245 | 245 |
| |
246 | 246 |
| |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + |
0 commit comments
Comments
(0)