NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit38587d7

committed

Error out on send failure in walsender loop.

I changed the loop in 9.3 to use "goto send_failure" instead of "break" onerrors, but I missed this one case. It was a relatively harmless bug: ifthe flush fails once it will most likely fail again as soon as we try toflush the output again. But it's a bug nevertheless.Report and fix by Andres Freund.

1 parentf5f2131 commit38587d7Copy full SHA for 38587d7

File tree

1 file changed

-1

lines changed

src/backend/replication
- walsender.c

1 file changed

-1

lines changed

`‎src/backend/replication/walsender.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1100,7 +1100,7 @@ WalSndLoop(void)`
`1100`	`1100`	`ping_sent= true;`
`1101`	`1101`	`/* Try to flush pending output to the client */`
`1102`	`1102`	`if (pq_flush_if_writable()!=0)`
`1103`		`-break;`
	`1103`	`+gotosend_failure;`
`1104`	`1104`	`}`
`1105`	`1105`	`}`
`1106`	`1106`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit38587d7

File tree

1 file changed

1 file changed

`‎src/backend/replication/walsender.c`

0 commit comments