NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit37fb017

committed

In plpgsql, allow foreign tables to define row types.

This seems to have been just an oversight in previous foreign-table work.A quick grep didn't turn up any other places where RELKIND_FOREIGN_TABLEwas obviously omitted.One change noted by Alexander Soudakov, the other by me.Back-patch to 9.1.

1 parent07d5205 commit37fb017Copy full SHA for 37fb017

File tree

1 file changed

-4

lines changed

src/pl/plpgsql/src
- pl_comp.c

1 file changed

-4

lines changed

`‎src/pl/plpgsql/src/pl_comp.c`

Lines changed: 6 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -1721,12 +1721,13 @@ plpgsql_parse_cwordtype(List *idents)`
`1721`	`1721`	`classStruct= (Form_pg_class)GETSTRUCT(classtup);`
`1722`	`1722`
`1723`	`1723`	`/*`
`1724`		`- * It must be a relation, sequence, view,or type`
	`1724`	`+ * It must be a relation, sequence, view,composite type, or foreign table`
`1725`	`1725`	`*/`
`1726`	`1726`	`if (classStruct->relkind!=RELKIND_RELATION&&`
`1727`	`1727`	`classStruct->relkind!=RELKIND_SEQUENCE&&`
`1728`	`1728`	`classStruct->relkind!=RELKIND_VIEW&&`
`1729`		`-classStruct->relkind!=RELKIND_COMPOSITE_TYPE)`
	`1729`	`+classStruct->relkind!=RELKIND_COMPOSITE_TYPE&&`
	`1730`	`+classStruct->relkind!=RELKIND_FOREIGN_TABLE)`
`1730`	`1731`	`gotodone;`
`1731`	`1732`
`1732`	`1733`	`/*`
`@@ -1947,11 +1948,12 @@ build_row_from_class(Oid classOid)`
`1947`	`1948`	`classStruct=RelationGetForm(rel);`
`1948`	`1949`	`relname=RelationGetRelationName(rel);`
`1949`	`1950`
`1950`		`-/* accept relation, sequence, view,orcomposite type entries */`
	`1951`	`+/* accept relation, sequence, view, composite type, or foreign table */`
`1951`	`1952`	`if (classStruct->relkind!=RELKIND_RELATION&&`
`1952`	`1953`	`classStruct->relkind!=RELKIND_SEQUENCE&&`
`1953`	`1954`	`classStruct->relkind!=RELKIND_VIEW&&`
`1954`		`-classStruct->relkind!=RELKIND_COMPOSITE_TYPE)`
	`1955`	`+classStruct->relkind!=RELKIND_COMPOSITE_TYPE&&`
	`1956`	`+classStruct->relkind!=RELKIND_FOREIGN_TABLE)`
`1955`	`1957`	`ereport(ERROR,`
`1956`	`1958`	`(errcode(ERRCODE_WRONG_OBJECT_TYPE),`
`1957`	`1959`	`errmsg("relation \"%s\" is not a table",relname)));`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit37fb017

File tree

1 file changed

1 file changed

`‎src/pl/plpgsql/src/pl_comp.c`

0 commit comments