forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit37d2ff3
committed
pg_rewind: Refactor the abstraction to fetch from local/libpq source.
This makes the abstraction of a "source" server more clear, by introducinga common abstract class, borrowing the object-oriented programming term,that represents all the operations that can be done on the source server.There are two implementations of it, one for fetching via libpq, andanother to fetch from a local directory. This adds some code, but makes iteasier to understand what's going on.The copy_executeFileMap() and libpq_executeFileMap() functions containedbasically the same logic, just calling different functions to fetch thesource files. Refactor so that the common logic is in one place, in a newfunction called perform_rewind().Reviewed-by: Kyotaro Horiguchi, Soumyadeep ChakrabortyDiscussion:https://www.postgresql.org/message-id/0c5b3783-af52-3ee5-f8fa-6e794061f70d%40iki.fi1 parentf81e97d commit37d2ff3
File tree
12 files changed
+697
-631
lines changed- src
- bin/pg_rewind
- tools/pgindent
12 files changed
+697
-631
lines changedLines changed: 2 additions & 3 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
20 | 20 |
| |
21 | 21 |
| |
22 | 22 |
| |
23 |
| - | |
24 | 23 |
| |
25 |
| - | |
26 | 24 |
| |
27 | 25 |
| |
28 |
| - | |
| 26 | + | |
| 27 | + | |
29 | 28 |
| |
30 | 29 |
| |
31 | 30 |
| |
|
Lines changed: 0 additions & 266 deletions
This file was deleted.
Lines changed: 0 additions & 60 deletions
This file was deleted.
Lines changed: 0 additions & 44 deletions
This file was deleted.
0 commit comments
Comments
(0)