NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit37c6923

committed

Fix -Wmissing-variable-declarations warnings for float.c special case

This adds extern declarations for the global variables defined infloat.c but not meant for external use. This is a workaround to beable to add -Wmissing-variable-declarations to the global set ofwarning options in the near future.Reviewed-by: Andres Freund <andres@anarazel.de>Discussion:https://www.postgresql.org/message-id/flat/e0a62134-83da-4ba4-8cdb-ceb0111c95ce@eisentraut.org

1 parentab61c40 commit37c6923Copy full SHA for 37c6923

File tree

1 file changed

-1

lines changed

src/backend/utils/adt
- float.c

1 file changed

-1

lines changed

`‎src/backend/utils/adt/float.c`

Lines changed: 9 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,15 @@ static float8 cot_45 = 0;`
`55`	`55`	`* be referenced by other files, much less changed; but we don't want the`
`56`	`56`	`* compiler to know that, else it might try to precompute expressions`
`57`	`57`	`* involving them. See comments for init_degree_constants().`
`58`		`- */`
	`58`	`+ *`
	`59`	`+ * The additional extern declarations are to silence`
	`60`	`+ * -Wmissing-variable-declarations.`
	`61`	`+ */`
	`62`	`+externfloat8degree_c_thirty;`
	`63`	`+externfloat8degree_c_forty_five;`
	`64`	`+externfloat8degree_c_sixty;`
	`65`	`+externfloat8degree_c_one_half;`
	`66`	`+externfloat8degree_c_one;`
`59`	`67`	`float8degree_c_thirty=30.0;`
`60`	`68`	`float8degree_c_forty_five=45.0;`
`61`	`69`	`float8degree_c_sixty=60.0;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit37c6923

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/float.c`

0 commit comments