NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit371668a

committed

Fix GiST buffering build to work when there are included columns.

gistRelocateBuildBuffersOnSplit did not get the memo about whichattribute count to use. This could lead to a crash if there wereincluded columns and buffering build was chosen. (Because thereare random page-split decisions elsewhere in GiST index build,the crashes are not entirely deterministic.)Back-patch to v12 where GiST gained support for included columns.Pavel BorisovDiscussion:https://postgr.es/m/CALT9ZEECCV5m7wvxg46PC-7x-EybUmnpupBGhSFMoAAay+r6HQ@mail.gmail.com

1 parent78c0b6e commit371668aCopy full SHA for 371668a

File tree

1 file changed

-2

lines changed

src/backend/access/gist
- gistbuildbuffers.c

1 file changed

-2

lines changed

`‎src/backend/access/gist/gistbuildbuffers.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -666,7 +666,7 @@ gistRelocateBuildBuffersOnSplit(GISTBuildBuffers gfbb, GISTSTATE giststate,`
`666`	`666`	`zero_penalty= true;`
`667`	`667`
`668`	`668`	`/* Loop over index attributes. */`
`669`		`-for (j=0;j<r->rd_att->natts;j++)`
	`669`	`+for (j=0;j<IndexRelationGetNumberOfKeyAttributes(r);j++)`
`670`	`670`	`{`
`671`	`671`	`floatusize;`
`672`	`672`
`@@ -692,7 +692,7 @@ gistRelocateBuildBuffersOnSplit(GISTBuildBuffers gfbb, GISTSTATE giststate,`
`692`	`692`	`which=i;`
`693`	`693`	`best_penalty[j]=usize;`
`694`	`694`
`695`		`-if (j<r->rd_att->natts-1)`
	`695`	`+if (j<IndexRelationGetNumberOfKeyAttributes(r)-1)`
`696`	`696`	`best_penalty[j+1]=-1;`
`697`	`697`	`}`
`698`	`698`	`elseif (best_penalty[j]==usize)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit371668a

File tree

1 file changed

1 file changed

`‎src/backend/access/gist/gistbuildbuffers.c`

0 commit comments