Commit36a8881

michaelpq

authored and

petere

committed

Fix code comments still referring to pg_start/stop_backup()

pg_start_backup() and pg_stop_backup() have been respectively renamed topg_backup_start() and pg_backup_stop() as of 39969e2, but a few commentsdid not get the call.Reviewed-by: Kyotaro Horiguchi, David SteeleDiscussion:https://postgr.es/m/YrqGlj1+4DF3dbZ/@paquier.xyz

1 parent72b6828 commit36a8881Copy full SHA for 36a8881

File tree

2 files changed

-2

lines changed

src/backend
- access/transam
  - xlogrecovery.c
- backup
  - basebackup.c

2 files changed

-2

lines changed

`‎src/backend/access/transam/xlogrecovery.c‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -717,7 +717,7 @@ InitWalRecovery(ControlFileData ControlFile, bool wasShutdown_ptr,`
`717`	`717`	`* know how far we need to replay the WAL before we reach consistency.`
`718`	`718`	`* This can happen for example if a base backup is taken from a`
`719`	`719`	`* running server using an atomic filesystem snapshot, without calling`
`720`		`- *pg_start/stop_backup. Or if you just kill a running primary server`
	`720`	`+ *pg_backup_start/stop. Or if you just kill a running primary server`
`721`	`721`	`* and put it into archive recovery by creating a recovery signal`
`722`	`722`	`* file.`
`723`	`723`	`*`

`‎src/backend/backup/basebackup.c‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@`
`16`	`16`	`#include<unistd.h>`
`17`	`17`	`#include<time.h>`
`18`	`18`
`19`		`-#include"access/xlog_internal.h"/* forpg_start/stop_backup */`
	`19`	`+#include"access/xlog_internal.h"/* forpg_backup_start/stop */`
`20`	`20`	`#include"backup/backup_manifest.h"`
`21`	`21`	`#include"backup/basebackup.h"`
`22`	`22`	`#include"backup/basebackup_sink.h"`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit36a8881

File tree

2 files changed

2 files changed

`‎src/backend/access/transam/xlogrecovery.c‎`

`‎src/backend/backup/basebackup.c‎`

0 commit comments