Commit36758c4

committed

Add CHECK_FOR_INTERRUPTS() to the repeat() function

The repeat() function loops for potentially a long time withoutever checking for interrupts. This prevents, for example, a querycancel from interrupting until the work is all done. Fix byinserting a CHECK_FOR_INTERRUPTS() into the loop.Backpatch to all supported versions.Discussion:https://www.postgresql.org/message-id/flat/8692553c-7fe8-17d9-cbc1-7cddb758f4c6%40joeconway.com

1 parent34301c9 commit36758c4Copy full SHA for 36758c4

File tree

-1

lines changed

-1

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@`
`19`	`19`	`#include"utils/builtins.h"`
`20`	`20`	`#include"utils/formatting.h"`
`21`	`21`	`#include"mb/pg_wchar.h"`
`22`		`-`
	`22`	`+#include"miscadmin.h"`
`23`	`23`
`24`	`24`	`statictextdotrim(constcharstring,intstringlen,`
`25`	`25`	`constchar*set,intsetlen,`
`@@ -1062,6 +1062,7 @@ repeat(PG_FUNCTION_ARGS)`
`1062`	`1062`	`{`
`1063`	`1063`	`memcpy(cp,sp,slen);`
`1064`	`1064`	`cp+=slen;`
	`1065`	`+CHECK_FOR_INTERRUPTS();`
`1065`	`1066`	`}`
`1066`	`1067`
`1067`	`1068`	`PG_RETURN_TEXT_P(result);`

Comments

(0)