NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit366d2a3

committed

pg_dump: Fix minor memory leak

Missing a destroyPQExpBuffer() in the early exit branch. The earlyexits aren't really necessary. Most similar functions just proceedrunning the rest of the code zero times and clean up at the end.

1 parent5654912 commit366d2a3Copy full SHA for 366d2a3

File tree

1 file changed

-18

lines changed

src/bin/pg_dump
- pg_dump.c

1 file changed

-18

lines changed

`‎src/bin/pg_dump/pg_dump.c‎`

Lines changed: 0 additions & 18 deletions

Original file line number	Diff line number	Diff line change
`@@ -3360,15 +3360,6 @@ getPublications(Archive *fout)`
`3360`	`3360`
`3361`	`3361`	`ntups = PQntuples(res);`
`3362`	`3362`
`3363`		`-if (ntups == 0)`
`3364`		`-{`
`3365`		`-/*`
`3366`		`- * There are no publications defined. Clean up and return.`
`3367`		`- */`
`3368`		`-PQclear(res);`
`3369`		`-return;`
`3370`		`-}`
`3371`		`-`
`3372`	`3363`	`i_tableoid = PQfnumber(res, "tableoid");`
`3373`	`3364`	`i_oid = PQfnumber(res, "oid");`
`3374`	`3365`	`i_pubname = PQfnumber(res, "pubname");`
`@@ -3637,15 +3628,6 @@ getSubscriptions(Archive *fout)`
`3637`	`3628`
`3638`	`3629`	`ntups = PQntuples(res);`
`3639`	`3630`
`3640`		`-if (ntups == 0)`
`3641`		`-{`
`3642`		`-/*`
`3643`		`- * There are no subscriptions defined. Clean up and return.`
`3644`		`- */`
`3645`		`-PQclear(res);`
`3646`		`-return;`
`3647`		`-}`
`3648`		`-`
`3649`	`3631`	`i_tableoid = PQfnumber(res, "tableoid");`
`3650`	`3632`	`i_oid = PQfnumber(res, "oid");`
`3651`	`3633`	`i_subname = PQfnumber(res, "subname");`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit366d2a3

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/pg_dump.c‎`

0 commit comments