forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit36389a0
committed
Enable RandomizedBaseAddress (ASLR) on Windows with MSVC builds
This has as effect to add /DYNAMICBASE to the .dll and .exe filesgenerated by the builds, undoing7f3e17b. Note that ASLR was alreadyenabled in MinGW as we have never added --disable-dynamicbase there.This change will ease a bit the integration of arm64 with MSVC, as ASLRsupport is mandatory in this case. So, thanks to this commit, we haveno need to make ASLR conditional depending on the architecture used forthe build.Andres Freund has done a lot of testing with this option while workingon meson, without seeing /DYNAMICBASE as being a problem in the Windowsbuilds of the CI. Personally, not supporting anything older thanWindows 10 on HEAD makes me feel safer about this change, as we haveseen ASLR with being a problem in process invocation particularly withWindows 8 and server 2012 back in 2014, even if Windows 10 was notreally a thing back then.45e004f is also something that can help inmaking the process invocation more stable. We are very early in thedevelopment of Postgres 16, giving a lot of room to detect stabilityissues if any.Discussion:https://postgr.es/m/20220826012907.gjw3jdqdgsts5y65@awork3.anarazel.de1 parent94077df commit36389a0
1 file changed
+0
-1
lines changedLines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
347 | 347 | | |
348 | 348 | | |
349 | 349 | | |
350 | | - | |
351 | 350 | | |
352 | 351 | | |
353 | 352 | | |
| |||
0 commit comments
Comments
(0)