NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit360abc0

committed

Be sure to release proc->backendLock after SetupLockInTable() failure.

The various places that transferred fast-path locks to the main lock tableneglected to release the PGPROC's backendLock if SetupLockInTable faileddue to being out of shared memory. In most cases this is no big deal sinceensuing error cleanup would release all held LWLocks anyway. But there aresome hot-standby functions that don't consider failure ofFastPathTransferRelationLocks to be a hard error, and in those cases thisoversight could lead to system lockup. For consistency, make all of theseplaces look the same as FastPathTransferRelationLocks.Noted while looking for the cause of Dan Wood's bugs --- this wasn't it,but it's a bug anyway.

1 parentc357be2 commit360abc0Copy full SHA for 360abc0

File tree

1 file changed

-0

lines changed

src/backend/storage/lmgr
- lock.c

1 file changed

-0

lines changed

`‎src/backend/storage/lmgr/lock.c`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2537,6 +2537,7 @@ FastPathTransferRelationLocks(LockMethod lockMethodTable, const LOCKTAG *locktag`
`2537`	`2537`	`if (!proclock)`
`2538`	`2538`	`{`
`2539`	`2539`	`LWLockRelease(partitionLock);`
	`2540`	`+LWLockRelease(proc->backendLock);`
`2540`	`2541`	`return false;`
`2541`	`2542`	`}`
`2542`	`2543`	`GrantLock(proclock->tag.myLock,proclock,lockmode);`
`@@ -2592,6 +2593,7 @@ FastPathGetRelationLockEntry(LOCALLOCK *locallock)`
`2592`	`2593`	`if (!proclock)`
`2593`	`2594`	`{`
`2594`	`2595`	`LWLockRelease(partitionLock);`
	`2596`	`+LWLockRelease(MyProc->backendLock);`
`2595`	`2597`	`ereport(ERROR,`
`2596`	`2598`	`(errcode(ERRCODE_OUT_OF_MEMORY),`
`2597`	`2599`	`errmsg("out of shared memory"),`
`@@ -4055,6 +4057,7 @@ VirtualXactLock(VirtualTransactionId vxid, bool wait)`
`4055`	`4057`	`if (!proclock)`
`4056`	`4058`	`{`
`4057`	`4059`	`LWLockRelease(partitionLock);`
	`4060`	`+LWLockRelease(proc->backendLock);`
`4058`	`4061`	`ereport(ERROR,`
`4059`	`4062`	`(errcode(ERRCODE_OUT_OF_MEMORY),`
`4060`	`4063`	`errmsg("out of shared memory"),`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit360abc0

File tree

1 file changed

1 file changed

`‎src/backend/storage/lmgr/lock.c`

0 commit comments