forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit357ff66
committed
Consider parallel awareness when removing single-child Appends
8edd0e7 added some code to remove Append and MergeAppend nodes when theycontained a single child node. As it turned out, this was unsafe to dowhen the Append/MergeAppend was parallel_aware and the child node was not.Removing the Append/MergeAppend, in this case, could lead to the child planbeing called multiple times by parallel workers when it was unsafe to doso.Here we fix this by just not removing the Append/MergeAppend when theparallel_aware flag of the parent and child node don't match.Reported-by: Yura SokolovBug: #17335Discussion:https://postgr.es/m/b59605fecb20ba9ea94e70ab60098c237c870628.camel%40postgrespro.ruBackpatch-through: 12, where8edd0e7 was first introduced1 parent29d9da3 commit357ff66
1 file changed
+20
-4
lines changedLines changed: 20 additions & 4 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
1522 | 1522 |
| |
1523 | 1523 |
| |
1524 | 1524 |
| |
1525 |
| - | |
1526 |
| - | |
| 1525 | + | |
| 1526 | + | |
| 1527 | + | |
| 1528 | + | |
| 1529 | + | |
| 1530 | + | |
| 1531 | + | |
| 1532 | + | |
| 1533 | + | |
| 1534 | + | |
1527 | 1535 |
| |
1528 | 1536 |
| |
1529 | 1537 |
| |
| |||
1586 | 1594 |
| |
1587 | 1595 |
| |
1588 | 1596 |
| |
1589 |
| - | |
1590 |
| - | |
| 1597 | + | |
| 1598 | + | |
| 1599 | + | |
| 1600 | + | |
| 1601 | + | |
| 1602 | + | |
| 1603 | + | |
| 1604 | + | |
| 1605 | + | |
| 1606 | + | |
1591 | 1607 |
| |
1592 | 1608 |
| |
1593 | 1609 |
| |
|
0 commit comments
Comments
(0)