NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit35532e3

committed

Doc: improve description of trim() and related functions.

Per bug #14441 from Mark Pether, the documentation could be misread,mainly because some of the examples failed to show what happens witha multicharacter "characters to trim" string. Also, while the textdescription in most of these entries was fairly clear that the"characters" argument is a set of characters not a substring to match,some of them used variant wording that was a bit less clear.trim() itself suffered from both deficiencies and was thus prettymisinterpretable.Also fix failure to explain which of LEADING/TRAILING/BOTH is thedefault.Discussion:https://postgr.es/m/20161130011710.6539.53657@wrigleys.postgresql.org

1 parenteacdd5d commit35532e3Copy full SHA for 35532e3

File tree

1 file changed

+14

-13

lines changed

doc/src/sgml
- func.sgml

1 file changed

+14

-13

lines changed

`‎doc/src/sgml/func.sgml`

Lines changed: 14 additions & 13 deletions

Original file line number	Diff line number	Diff line change
`@@ -1306,11 +1306,12 @@`
`1306`	`1306`	`</entry>`
`1307`	`1307`	`<entry><type>text</type></entry>`
`1308`	`1308`	`<entry>`
`1309`		`- Remove the longest string containing onlythe`
	`1309`	`+ Remove the longest string containing onlycharacters from`
`1310`	`1310`	`<parameter>characters</parameter> (a space by default) from the`
`1311`		`- start/end/both ends of the <parameter>string</parameter>`
	`1311`	`+ start, end, or both ends (<literal>both</> is the default)`
	`1312`	`+ of <parameter>string</parameter>`
`1312`	`1313`	`</entry>`
`1313`		`- <entry><literal>trim(both 'x' from 'xTomxx')</literal></entry>`
	`1314`	`+ <entry><literal>trim(both 'xyz' from 'yxTomxx')</literal></entry>`
`1314`	`1315`	`<entry><literal>Tom</literal></entry>`
`1315`	`1316`	`</row>`
`1316`	`1317`
`@@ -1382,7 +1383,7 @@`
`1382`	`1383`	`in <parameter>characters</parameter> (a space by default)`
`1383`	`1384`	`from the start and end of <parameter>string</parameter>`
`1384`	`1385`	`</entry>`
`1385`		`- <entry><literal>btrim('xyxtrimyyx', 'xy')</literal></entry>`
	`1386`	`+ <entry><literal>btrim('xyxtrimyyx', 'xyz')</literal></entry>`
`1386`	`1387`	`<entry><literal>trim</literal></entry>`
`1387`	`1388`	`</row>`
`1388`	`1389`
`@@ -1651,8 +1652,8 @@`
`1651`	`1652`	`<parameter>characters</parameter> (a space by default) from the start of`
`1652`	`1653`	`<parameter>string</parameter>`
`1653`	`1654`	`</entry>`
`1654`		`- <entry><literal>ltrim('zzzytrim', 'xyz')</literal></entry>`
`1655`		`- <entry><literal>trim</literal></entry>`
	`1655`	`+ <entry><literal>ltrim('zzzytest', 'xyz')</literal></entry>`
	`1656`	`+ <entry><literal>test</literal></entry>`
`1656`	`1657`	`</row>`
`1657`	`1658`
`1658`	`1659`	`<row>`
`@@ -1934,8 +1935,8 @@`
`1934`	`1935`	`<parameter>characters</parameter> (a space by default) from the end of`
`1935`	`1936`	`<parameter>string</parameter>`
`1936`	`1937`	`</entry>`
`1937`		`- <entry><literal>rtrim('trimxxxx', 'x')</literal></entry>`
`1938`		`- <entry><literal>trim</literal></entry>`
	`1938`	`+ <entry><literal>rtrim('testxxzx', 'xyz')</literal></entry>`
	`1939`	`+ <entry><literal>test</literal></entry>`
`1939`	`1940`	`</row>`
`1940`	`1941`
`1941`	`1942`	`<row>`
`@@ -3199,11 +3200,11 @@ SELECT format('Testing %3$s, %2$s, %s', 'one', 'two', 'three');`
`3199`	`3200`	`</entry>`
`3200`	`3201`	`<entry><type>bytea</type></entry>`
`3201`	`3202`	`<entry>`
`3202`		`- Remove the longest string containing onlythebytes in`
	`3203`	`+ Remove the longest string containing only bytes appearing in`
`3203`	`3204`	`<parameter>bytes</parameter> from the start`
`3204`	`3205`	`and end of <parameter>string</parameter>`
`3205`	`3206`	`</entry>`
`3206`		`- <entry><literal>trim(E'\\000'::bytea from E'\\000Tom\\000'::bytea)</literal></entry>`
	`3207`	`+ <entry><literal>trim(E'\\000\\001'::bytea from E'\\000Tom\\001'::bytea)</literal></entry>`
`3207`	`3208`	`<entry><literal>Tom</literal></entry>`
`3208`	`3209`	`</row>`
`3209`	`3210`	`</tbody>`
`@@ -3242,11 +3243,11 @@ SELECT format('Testing %3$s, %2$s, %s', 'one', 'two', 'three');`
`3242`	`3243`	`</entry>`
`3243`	`3244`	`<entry><type>bytea</type></entry>`
`3244`	`3245`	`<entry>`
`3245`		`- Remove the longest stringconsisting onlyofbytes`
`3246`		`-in<parameter>bytes</parameter> from the start and end of`
	`3246`	`+ Remove the longest stringcontaining only bytes appearing in`
	`3247`	`+ <parameter>bytes</parameter> from the start and end of`
`3247`	`3248`	`<parameter>string</parameter>`
`3248`	`3249`	`</entry>`
`3249`		`- <entry><literal>btrim(E'\\000trim\\000'::bytea, E'\\000'::bytea)</literal></entry>`
	`3250`	`+ <entry><literal>btrim(E'\\000trim\\001'::bytea, E'\\000\\001'::bytea)</literal></entry>`
`3250`	`3251`	`<entry><literal>trim</literal></entry>`
`3251`	`3252`	`</row>`
`3252`	`3253`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit35532e3

File tree

1 file changed

1 file changed

`‎doc/src/sgml/func.sgml`

0 commit comments