NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit350410b

committed

Add missing quote_identifier calls for CREATE TRIGGER ... REFERENCING.

Mixed-case names for transition tables weren't dumped correctly.Oversight in commit8c48375, per bug #15440 from Karl Czajkowski.In passing, I couldn't resist a bit of code beautification.Back-patch to v10 where this was introduced.Discussion:https://postgr.es/m/15440-02d1468e94d63d76@postgresql.org

1 parent197e4af commit350410bCopy full SHA for 350410b

File tree

1 file changed

-4

lines changed

src/backend/utils/adt
- ruleutils.c

1 file changed

-4

lines changed

`‎src/backend/utils/adt/ruleutils.c`

Lines changed: 6 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -954,22 +954,24 @@ pg_get_triggerdef_worker(Oid trigid, bool pretty)`
`954`	`954`	`value=fastgetattr(ht_trig,Anum_pg_trigger_tgoldtable,`
`955`	`955`	`tgrel->rd_att,&isnull);`
`956`	`956`	`if (!isnull)`
`957`		`-tgoldtable=NameStr(((NameData)DatumGetPointer(value)));`
	`957`	`+tgoldtable=NameStr(*DatumGetName(value));`
`958`	`958`	`else`
`959`	`959`	`tgoldtable=NULL;`
`960`	`960`	`value=fastgetattr(ht_trig,Anum_pg_trigger_tgnewtable,`
`961`	`961`	`tgrel->rd_att,&isnull);`
`962`	`962`	`if (!isnull)`
`963`		`-tgnewtable=NameStr(((NameData)DatumGetPointer(value)));`
	`963`	`+tgnewtable=NameStr(*DatumGetName(value));`
`964`	`964`	`else`
`965`	`965`	`tgnewtable=NULL;`
`966`	`966`	`if (tgoldtable!=NULL\|\|tgnewtable!=NULL)`
`967`	`967`	`{`
`968`	`968`	`appendStringInfoString(&buf,"REFERENCING ");`
`969`	`969`	`if (tgoldtable!=NULL)`
`970`		`-appendStringInfo(&buf,"OLD TABLE AS %s ",tgoldtable);`
	`970`	`+appendStringInfo(&buf,"OLD TABLE AS %s ",`
	`971`	`+quote_identifier(tgoldtable));`
`971`	`972`	`if (tgnewtable!=NULL)`
`972`		`-appendStringInfo(&buf,"NEW TABLE AS %s ",tgnewtable);`
	`973`	`+appendStringInfo(&buf,"NEW TABLE AS %s ",`
	`974`	`+quote_identifier(tgnewtable));`
`973`	`975`	`}`
`974`	`976`
`975`	`977`	`if (TRIGGER_FOR_ROW(trigrec->tgtype))`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit350410b

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/ruleutils.c`

0 commit comments