NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit34e09e7

committed

Remove duplicate lines of code

Commit6df7a96 accidentally included two identical prototypes fordefault_multirange_selectivi() and commit086cf14 added a break;statement where one was already present, thus duplicating it. Whilethere is no bug caused by this, fix by removing the duplicated linesas they provide no value.Backpatch the fix for duplicate prototypes to v14 and the duplicatebreak statement fix to all supported branches to avoid backpatchinghazards due to the removal.Reported-by: Anton Voloshin <a.voloshin@postgrespro.ru>Discussion:https://postgr.es/m/0e69cb60-0176-f6d0-7e15-6478b7d85724@postgrespro.ru

1 parentf4a4a18 commit34e09e7Copy full SHA for 34e09e7

File tree

2 files changed

-2

lines changed

src
- backend/utils/adt
  - multirangetypes_selfuncs.c
- interfaces/ecpg/preproc
  - variable.c

2 files changed

-2

lines changed

`‎src/backend/utils/adt/multirangetypes_selfuncs.c`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,6 @@ static double calc_multirangesel(TypeCacheEntry *typcache,`
`35`	`35`	`VariableStatData*vardata,`
`36`	`36`	`constMultirangeType*constval,Oidoperator);`
`37`	`37`	`staticdoubledefault_multirange_selectivity(Oidoperator);`
`38`		`-staticdoubledefault_multirange_selectivity(Oidoperator);`
`39`	`38`	`staticdoublecalc_hist_selectivity(TypeCacheEntry*typcache,`
`40`	`39`	`VariableStatData*vardata,`
`41`	`40`	`constMultirangeType*constval,`

`‎src/interfaces/ecpg/preproc/variable.c`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,6 @@ find_struct_member(char name, char str, struct ECPGstruct_member *members, int`
`105`	`105`	`else`
`106`	`106`	`returnfind_struct_member(name,++end,members->type->u.members,brace_level);`
`107`	`107`	`break;`
`108`		`-break;`
`109`	`108`	`case'.':`
`110`	`109`	`if (members->type->type==ECPGt_array)`
`111`	`110`	`returnfind_struct_member(name,end,members->type->u.element->u.members,brace_level);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit34e09e7

File tree

2 files changed

2 files changed

`‎src/backend/utils/adt/multirangetypes_selfuncs.c`

`‎src/interfaces/ecpg/preproc/variable.c`

0 commit comments