NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit34a8b64

committed

Change recovery_init_sync_method to PGC_SIGHUP.

The setting has no effect except during startup. It's still nice to beable to change it dynamically, which is expected to be pretty useful toan admin following crash recovery when restarting the cluster is not soappealing.Per discussions following commits2941138 and61752af.Author: Justin Pryzby <pryzby@telsasoft.com>Reviewed-by: Fujii Masao <masao.fujii@oss.nttdata.com>Reviewed-by: Michael Paquier <michael@paquier.xyz>Reviewed-by: Thomas Munro <thomas.munro@gmail.com>Discussion:https://postgr.es/m/20210529192321.GM2082%40telsasoft.com

1 parent79718c1 commit34a8b64Copy full SHA for 34a8b64

File tree

3 files changed

-3

lines changed

doc/src/sgml
- config.sgml
src/backend/utils/misc
- guc.c
- postgresql.conf.sample

3 files changed

-3

lines changed

`‎doc/src/sgml/config.sgml`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -9929,7 +9929,8 @@ dynamic_library_path = 'C:\tools\postgresql;H:\my_project\lib;$libdir'`
`9929`	`9929`	`appear only in kernel logs.`
`9930`	`9930`	`</para>`
`9931`	`9931`	`<para>`
`9932`		`- This parameter can only be set at server start.`
	`9932`	`+ This parameter can only be set in the`
	`9933`	`+ <filename>postgresql.conf</filename> file or on the server command line.`
`9933`	`9934`	`</para>`
`9934`	`9935`	`</listitem>`
`9935`	`9936`	`</varlistentry>`

`‎src/backend/utils/misc/guc.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -4946,7 +4946,7 @@ static struct config_enum ConfigureNamesEnum[] =`
`4946`	`4946`	`},`
`4947`	`4947`
`4948`	`4948`	`{`
`4949`		`-{"recovery_init_sync_method",PGC_POSTMASTER,ERROR_HANDLING_OPTIONS,`
	`4949`	`+{"recovery_init_sync_method",PGC_SIGHUP,ERROR_HANDLING_OPTIONS,`
`4950`	`4950`	`gettext_noop("Sets the method for synchronizing the data directory before crash recovery."),`
`4951`	`4951`	`},`
`4952`	`4952`	`&recovery_init_sync_method,`

`‎src/backend/utils/misc/postgresql.conf.sample`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -772,7 +772,6 @@`
`772`	`772`	`# data?`
`773`	`773`	`# (change requires restart)`
`774`	`774`	`#recovery_init_sync_method = fsync# fsync, syncfs (Linux 5.8+)`
`775`		`-# (change requires restart)`
`776`	`775`
`777`	`776`
`778`	`777`	`#------------------------------------------------------------------------------`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit34a8b64

File tree

3 files changed

3 files changed

`‎doc/src/sgml/config.sgml`

`‎src/backend/utils/misc/guc.c`

`‎src/backend/utils/misc/postgresql.conf.sample`

0 commit comments