Commit345bf97

committed

Ignore PQcancel errors properly

Add a (void) cast to all PQcancel() calls that purposefully don't checkthe return value, to keep compilers and static checkers happy.Per Coverity.

1 parent57811b7 commit345bf97Copy full SHA for 345bf97

File tree

-4

lines changed

-4

lines changed

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -342,12 +342,12 @@ DisconnectDatabase(Archive *AHX)`
`342`	`342`	`if (AH->connCancel)`
`343`	`343`	`{`
`344`	`344`	`/*`
`345`		`- * If we have an active query, send a cancel before closing. This is`
`346`		`- * of no use for a normal exit, but might be helpful during`
`347`		`- * exit_horribly().`
	`345`	`+ * If we have an active query, send a cancel before closing, ignoring`
	`346`	`+ *any errors. This isof no use for a normal exit, but might be`
	`347`	`+ *helpful duringexit_horribly().`
`348`	`348`	`*/`
`349`	`349`	`if (PQtransactionStatus(AH->connection)==PQTRANS_ACTIVE)`
`350`		`-PQcancel(AH->connCancel,errbuf,sizeof(errbuf));`
	`350`	`+(void)PQcancel(AH->connCancel,errbuf,sizeof(errbuf));`
`351`	`351`
`352`	`352`	`/*`
`353`	`353`	`* Prevent signal handler from sending a cancel after this.`

Comments

(0)