NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit344a225

committed

Fix breakage in AlterFunction().

An ALTER FUNCTION command that tried to update both the function'sproparallel property and its proconfig list failed to do the former,because it stored the new proparallel value into a tuple that wasno longer the interesting one. Carelessness in7aea8e4.(I did not bother with a regression test, because the only likelyfuture breakage would be for someone to ignore the comment I addedand add some other field update after the heap_modify_tuple step.A test using existing function properties could not catch that.)Per report from Bryn Llewellyn. Back-patch to all supported branches.Discussion:https://postgr.es/m/8AC9A37F-99BD-446F-A2F7-B89AD0022774@yugabyte.com

1 parent83cca40 commit344a225Copy full SHA for 344a225

File tree

1 file changed

-2

lines changed

src/backend/commands
- functioncmds.c

1 file changed

-2

lines changed

`‎src/backend/commands/functioncmds.c`

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1472,6 +1472,8 @@ AlterFunction(ParseState pstate, AlterFunctionStmt stmt)`
`1472`	`1472`
`1473`	`1473`	`procForm->prosupport=newsupport;`
`1474`	`1474`	`}`
	`1475`	`+if (parallel_item)`
	`1476`	`+procForm->proparallel=interpret_func_parallel(parallel_item);`
`1475`	`1477`	`if (set_items)`
`1476`	`1478`	`{`
`1477`	`1479`	`Datumdatum;`
`@@ -1506,8 +1508,7 @@ AlterFunction(ParseState pstate, AlterFunctionStmt stmt)`
`1506`	`1508`	`tup=heap_modify_tuple(tup,RelationGetDescr(rel),`
`1507`	`1509`	`repl_val,repl_null,repl_repl);`
`1508`	`1510`	`}`
`1509`		`-if (parallel_item)`
`1510`		`-procForm->proparallel=interpret_func_parallel(parallel_item);`
	`1511`	`+/* DO NOT put more touches of procForm below here; it's now dangling. */`
`1511`	`1512`
`1512`	`1513`	`/* Do the update */`
`1513`	`1514`	`CatalogTupleUpdate(rel,&tup->t_self,tup);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit344a225

File tree

1 file changed

1 file changed

`‎src/backend/commands/functioncmds.c`

0 commit comments