NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit3420b24

committed

Fix dependency tracking for src/port/%_srv.o files

Because they use their own compilation rule, they don't use thedependency tracking logic from Makefile.global. To make sure thatdependency tracking works anyway for the *_srv.o files, depend ontheir *.o siblings as well, which do have proper dependencies. It's ahack that might fail someday if there is a *_srv.o without acorresponding *.o, but it works for now (and those would probably gointo src/backend/port/ anyway).

1 parentdcb2c58 commit3420b24Copy full SHA for 3420b24

File tree

1 file changed

-1

lines changed

src/port
- Makefile

1 file changed

-1

lines changed

`‎src/port/Makefile`

Lines changed: 8 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,14 @@ thread.o: CFLAGS+=$(PTHREAD_CFLAGS)`
`62`	`62`	`libpgport_srv.a:$(OBJS_SRV)`
`63`	`63`	`$(AR)$(AROPT)$@$^`
`64`	`64`
`65`		`-%_srv.o:%.c`
	`65`	`+# Because this uses its own compilation rule, it doesn't use the`
	`66`	`+# dependency tracking logic from Makefile.global. To make sure that`
	`67`	`+# dependency tracking works anyway for the *_srv.o files, depend on`
	`68`	`+# their *.o siblings as well, which do have proper dependencies. It's`
	`69`	`+# a hack that might fail someday if there is a *_srv.o without a`
	`70`	`+# corresponding *.o, but it works for now (and those would probably go`
	`71`	`+# into src/backend/port/ anyway).`
	`72`	`+%_srv.o:%.c%.o`
`66`	`73`	`$(CC)$(CFLAGS)$(subst -DFRONTEND,,$(CPPFLAGS)) -c$< -o$@`
`67`	`74`
`68`	`75`	`$(OBJS_SRV): \| submake-errcodes`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit3420b24

File tree

1 file changed

1 file changed

`‎src/port/Makefile`

0 commit comments