NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit3414099

committed

Try to stabilize the reloptions test.

Where we test vacuum_truncate's effects, sometimes this is failing totruncate as expected on the build farm. That could be explained by pageskipping, so disable it explicitly, with the theory that commitfe246d1didn't go far enough.Back-patch to 12, where the vacuum_truncate tests were added.Discussion:https://postgr.es/m/CA%2BhUKGLT2UL5_JhmBzUgkdyKfc%3D5J-gJSQJLysMs4rqLUKLAzw%40mail.gmail.com

1 parentdda42ff commit3414099Copy full SHA for 3414099

File tree

2 files changed

-4

lines changed

src/test/regress
- expected
  - reloptions.out
- sql
  - reloptions.sql

2 files changed

-4

lines changed

`‎src/test/regress/expected/reloptions.out`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ INSERT INTO reloptions_test VALUES (1, NULL), (NULL, NULL);`
`103`	`103`	`ERROR: null value in column "i" of relation "reloptions_test" violates not-null constraint`
`104`	`104`	`DETAIL: Failing row contains (null, null).`
`105`	`105`	`-- Do an aggressive vacuum to prevent page-skipping.`
`106`		`-VACUUM FREEZE reloptions_test;`
	`106`	`+VACUUM(FREEZE, DISABLE_PAGE_SKIPPING) reloptions_test;`
`107`	`107`	`SELECT pg_relation_size('reloptions_test') > 0;`
`108`	`108`	`?column?`
`109`	`109`	`----------`
`@@ -129,7 +129,7 @@ INSERT INTO reloptions_test VALUES (1, NULL), (NULL, NULL);`
`129`	`129`	`ERROR: null value in column "i" of relation "reloptions_test" violates not-null constraint`
`130`	`130`	`DETAIL: Failing row contains (null, null).`
`131`	`131`	`-- Do an aggressive vacuum to prevent page-skipping.`
`132`		`-VACUUM FREEZE reloptions_test;`
	`132`	`+VACUUM(FREEZE, DISABLE_PAGE_SKIPPING) reloptions_test;`
`133`	`133`	`SELECT pg_relation_size('reloptions_test') = 0;`
`134`	`134`	`?column?`
`135`	`135`	`----------`

`‎src/test/regress/sql/reloptions.sql`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ CREATE TABLE reloptions_test(i INT NOT NULL, j text)`
`62`	`62`	`SELECT reloptionsFROM pg_classWHEREoid='reloptions_test'::regclass;`
`63`	`63`	`INSERT INTO reloptions_testVALUES (1,NULL), (NULL,NULL);`
`64`	`64`	`-- Do an aggressive vacuum to prevent page-skipping.`
`65`		`-VACUUM FREEZE reloptions_test;`
	`65`	`+VACUUM(FREEZE, DISABLE_PAGE_SKIPPING) reloptions_test;`
`66`	`66`	`SELECT pg_relation_size('reloptions_test')>0;`
`67`	`67`
`68`	`68`	`SELECT reloptionsFROM pg_classWHEREoid=`
`@@ -73,7 +73,7 @@ ALTER TABLE reloptions_test RESET (vacuum_truncate);`
`73`	`73`	`SELECT reloptionsFROM pg_classWHEREoid='reloptions_test'::regclass;`
`74`	`74`	`INSERT INTO reloptions_testVALUES (1,NULL), (NULL,NULL);`
`75`	`75`	`-- Do an aggressive vacuum to prevent page-skipping.`
`76`		`-VACUUM FREEZE reloptions_test;`
	`76`	`+VACUUM(FREEZE, DISABLE_PAGE_SKIPPING) reloptions_test;`
`77`	`77`	`SELECT pg_relation_size('reloptions_test')=0;`
`78`	`78`
`79`	`79`	`-- Test toast.* options`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit3414099

File tree

2 files changed

2 files changed

`‎src/test/regress/expected/reloptions.out`

`‎src/test/regress/sql/reloptions.sql`

0 commit comments