forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit3409b4d
committed
Remove one memoize test case added by commit069d0ff.
This test case turns out to depend on the assumption that a non-Varsubquery output that's underneath an outer join will always getwrapped in a PlaceHolderVar. But that behavior causes performanceregressions in some cases compared to what happened before v16.The next commit will avoid inserting a PHV in the same cases wherepre-v16 did, and that causes get_memoized_path to not detect thata memoize plan could be used.Commit this separately, in hopes that we can restore the test aftermaking get_memoized_path smarter. (It's failing to find memoizeplans in adjacent cases where no PHV was ever inserted, so thereis definitely room for improvement there.)Discussion:https://postgr.es/m/CAG1ps1xvnTZceKK24OUfMKLPvDP2vjT-d+F2AOCWbw_v3KeEgg@mail.gmail.com1 parentc39afc3 commit3409b4d
2 files changed
+0
-41
lines changedLines changed: 0 additions & 30 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
160 | 160 |
| |
161 | 161 |
| |
162 | 162 |
| |
163 |
| - | |
164 |
| - | |
165 |
| - | |
166 |
| - | |
167 |
| - | |
168 |
| - | |
169 |
| - | |
170 |
| - | |
171 |
| - | |
172 |
| - | |
173 |
| - | |
174 |
| - | |
175 |
| - | |
176 |
| - | |
177 |
| - | |
178 |
| - | |
179 |
| - | |
180 |
| - | |
181 |
| - | |
182 |
| - | |
183 |
| - | |
184 |
| - | |
185 |
| - | |
186 |
| - | |
187 |
| - | |
188 |
| - | |
189 |
| - | |
190 |
| - | |
191 |
| - | |
192 |
| - | |
193 | 163 |
| |
194 | 164 |
| |
195 | 165 |
| |
|
Lines changed: 0 additions & 11 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
85 | 85 |
| |
86 | 86 |
| |
87 | 87 |
| |
88 |
| - | |
89 |
| - | |
90 |
| - | |
91 |
| - | |
92 |
| - | |
93 |
| - | |
94 |
| - | |
95 |
| - | |
96 |
| - | |
97 |
| - | |
98 |
| - | |
99 | 88 |
| |
100 | 89 |
| |
101 | 90 |
| |
|
0 commit comments
Comments
(0)