Commit33bfbef

committed

Review wording on tablespaces w.r.t. partitioned tables

Remove a redundant comment, and document pg_class.reltablespace properlyin catalogs.sgml.After commitsa36c84c,8725958 and others.Backpatch to 12.Discussion:https://postgr.es/m/202403191013.w2kr7wqlamqz@alvherre.pgsql

1 parent262757b commit33bfbefCopy full SHA for 33bfbef

File tree

-7

lines changed

-7

lines changed

Lines changed: 6 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1970,9 +1970,12 @@ SCRAM-SHA-256$<replaceable><iteration count></replaceable>:<replaceable>&l`
`1970`	`1970`	`(references <link linkend="catalog-pg-tablespace"><structname>pg_tablespace</structname></link>.<structfield>oid</structfield>)`
`1971`	`1971`	`</para>`
`1972`	`1972`	`<para>`
`1973`		`- The tablespace in which this relation is stored. If zero,`
`1974`		`- the database's default tablespace is implied. (Not meaningful`
`1975`		`- if the relation has no on-disk file.)`
	`1973`	`+ The tablespace in which this relation is stored.`
	`1974`	`+ If zero, the database's default tablespace is implied.`
	`1975`	`+ Not meaningful if the relation has no on-disk file,`
	`1976`	`+ except for partitioned tables, where this is the tablespace`
	`1977`	`+ in which partitions will be created when one is not`
	`1978`	`+ specified in the creation command.`
`1976`	`1979`	`</para></entry>`
`1977`	`1980`	`</row>`
`1978`	`1981`

Lines changed: 0 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -755,10 +755,6 @@ DefineRelation(CreateStmt *stmt, char relkind, Oid ownerId,`
`755`	`755`	`}`
`756`	`756`	`else if (stmt->partbound)`
`757`	`757`	`{`
`758`		`-/*`
`759`		`- * For partitions, when no other tablespace is specified, we default`
`760`		`- * the tablespace to the parent partitioned table's.`
`761`		`- */`
`762`	`758`	`Assert(list_length(inheritOids) == 1);`
`763`	`759`	`tablespaceId = get_rel_tablespace(linitial_oid(inheritOids));`
`764`	`760`	`}`

Comments

(0)