NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit33a94ba

committed

Remove unused smgrdounlinkfork() function.

smgrdounlinkfork() became dead code as the result of commitece01aa,but it was left in place just in case we want it someday. However no usershave appeared in 7 years, so it's time to remove this unused function.Author: Kirk JamisonDiscussion:https://www.postgresql.org/message-id/D09B13F772D2274BB348A310EE3027C64E2067@g01jpexmbkw24

1 parentf9f2fda commit33a94baCopy full SHA for 33a94ba

File tree

2 files changed

-56

lines changed

src
- backend/storage/smgr
  - smgr.c
- include/storage
  - smgr.h

2 files changed

-56

lines changed

`‎src/backend/storage/smgr/smgr.c`

Lines changed: 0 additions & 55 deletions

Original file line number	Diff line number	Diff line change
`@@ -343,9 +343,6 @@ smgrcreate(SMgrRelation reln, ForkNumber forknum, bool isRedo)`
`343`	`343`	`*`
`344`	`344`	`*If isRedo is true, it is okay for the underlying file(s) to be gone`
`345`	`345`	`*already.`
`346`		`- *`
`347`		`- *This is equivalent to calling smgrdounlinkfork for each fork, but`
`348`		`- *it's significantly quicker so should be preferred when possible.`
`349`	`346`	`*/`
`350`	`347`	`void`
`351`	`348`	`smgrdounlink(SMgrRelationreln,boolisRedo)`
`@@ -472,58 +469,6 @@ smgrdounlinkall(SMgrRelation *rels, int nrels, bool isRedo)`
`472`	`469`	`pfree(rnodes);`
`473`	`470`	`}`
`474`	`471`
`475`		`-/*`
`476`		`- *smgrdounlinkfork() -- Immediately unlink one fork of a relation.`
`477`		`- *`
`478`		`- *The specified fork of the relation is removed from the store. This`
`479`		`- *should not be used during transactional operations, since it can't be`
`480`		`- *undone.`
`481`		`- *`
`482`		`- *If isRedo is true, it is okay for the underlying file to be gone`
`483`		`- *already.`
`484`		`- */`
`485`		`-void`
`486`		`-smgrdounlinkfork(SMgrRelationreln,ForkNumberforknum,boolisRedo)`
`487`		`-{`
`488`		`-RelFileNodeBackendrnode=reln->smgr_rnode;`
`489`		`-intwhich=reln->smgr_which;`
`490`		`-`
`491`		`-/* Close the fork at smgr level */`
`492`		`-smgrsw[which].smgr_close(reln,forknum);`
`493`		`-`
`494`		`-/*`
`495`		`- * Get rid of any remaining buffers for the fork. bufmgr will just drop`
`496`		`- * them without bothering to write the contents.`
`497`		`- */`
`498`		`-DropRelFileNodeBuffers(rnode,forknum,0);`
`499`		`-`
`500`		`-/*`
`501`		`- * It'd be nice to tell the stats collector to forget it immediately, too.`
`502`		`- * But we can't because we don't know the OID (and in cases involving`
`503`		`- * relfilenode swaps, it's not always clear which table OID to forget,`
`504`		`- * anyway).`
`505`		`- */`
`506`		`-`
`507`		`-/*`
`508`		`- * Send a shared-inval message to force other backends to close any`
`509`		`- * dangling smgr references they may have for this rel. We should do this`
`510`		`- * before starting the actual unlinking, in case we fail partway through`
`511`		`- * that step. Note that the sinval message will eventually come back to`
`512`		`- * this backend, too, and thereby provide a backstop that we closed our`
`513`		`- * own smgr rel.`
`514`		`- */`
`515`		`-CacheInvalidateSmgr(rnode);`
`516`		`-`
`517`		`-/*`
`518`		`- * Delete the physical file(s).`
`519`		`- *`
`520`		`- * Note: smgr_unlink must treat deletion failure as a WARNING, not an`
`521`		`- * ERROR, because we've already decided to commit or abort the current`
`522`		`- * xact.`
`523`		`- */`
`524`		`-smgrsw[which].smgr_unlink(rnode,forknum,isRedo);`
`525`		`-}`
`526`		`-`
`527`	`472`	`/*`
`528`	`473`	`*smgrextend() -- Add a new block to a file.`
`529`	`474`	`*`

`‎src/include/storage/smgr.h`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,6 @@ extern void smgrclosenode(RelFileNodeBackend rnode);`
`90`	`90`	`externvoidsmgrcreate(SMgrRelationreln,ForkNumberforknum,boolisRedo);`
`91`	`91`	`externvoidsmgrdounlink(SMgrRelationreln,boolisRedo);`
`92`	`92`	`externvoidsmgrdounlinkall(SMgrRelation*rels,intnrels,boolisRedo);`
`93`		`-externvoidsmgrdounlinkfork(SMgrRelationreln,ForkNumberforknum,boolisRedo);`
`94`	`93`	`externvoidsmgrextend(SMgrRelationreln,ForkNumberforknum,`
`95`	`94`	`BlockNumberblocknum,char*buffer,boolskipFsync);`
`96`	`95`	`externvoidsmgrprefetch(SMgrRelationreln,ForkNumberforknum,`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit33a94ba

File tree

2 files changed

2 files changed

`‎src/backend/storage/smgr/smgr.c`

`‎src/include/storage/smgr.h`

0 commit comments