NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit3353974

Amit Kapila

committed

Move MarkCurrentTransactionIdLoggedIfAny() out of the critical section.

We don't modify any shared state in this function which could causeproblems for any concurrent session. This will make it look similar to theother updates for the same structure (TransactionState) which avoidsconfusion for future readers of code.Author: Dilip KumarReviewed-by: Amit KapilaDiscussion:https://postgr.es/m/E1mSoYz-0007Fh-D9@gemulon.postgresql.org

1 parent71db645 commit3353974Copy full SHA for 3353974

File tree

1 file changed

-2

lines changed

src/backend/access/transam
- xlog.c

1 file changed

-2

lines changed

`‎src/backend/access/transam/xlog.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1169,10 +1169,10 @@ XLogInsertRecord(XLogRecData *rdata,`
`1169`	`1169`	`*/`
`1170`	`1170`	`WALInsertLockRelease();`
`1171`	`1171`
`1172`		`-MarkCurrentTransactionIdLoggedIfAny();`
`1173`		`-`
`1174`	`1172`	`END_CRIT_SECTION();`
`1175`	`1173`
	`1174`	`+MarkCurrentTransactionIdLoggedIfAny();`
	`1175`	`+`
`1176`	`1176`	`/*`
`1177`	`1177`	`* Mark top transaction id is logged (if needed) so that we should not try`
`1178`	`1178`	`* to log it again with the next WAL record in the current subtransaction.`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit3353974

File tree

1 file changed

1 file changed

`‎src/backend/access/transam/xlog.c`

0 commit comments