NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit3344451

committed

Reuse all-zero pages in GIN.

In GIN, an all-zeros page would be leaked forever, and never reused. Justadd them to the FSM in vacuum, and they will be reinitialized when grabbedfrom the FSM. On master and 9.5, attempting to access the page's opaquestruct also caused an assertion failure, although that was otherwiseharmless.Reported by Jeff Janes. Backpatch to all supported versions.

1 parent023430a commit3344451Copy full SHA for 3344451

File tree

1 file changed

-1

lines changed

src/backend/access/gin
- ginvacuum.c

1 file changed

-1

lines changed

`‎src/backend/access/gin/ginvacuum.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -710,7 +710,7 @@ ginvacuumcleanup(PG_FUNCTION_ARGS)`
`710`	`710`	`LockBuffer(buffer,GIN_SHARE);`
`711`	`711`	`page= (Page)BufferGetPage(buffer);`
`712`	`712`
`713`		`-if (GinPageIsDeleted(page))`
	`713`	`+if (PageIsNew(page)\|\|GinPageIsDeleted(page))`
`714`	`714`	`{`
`715`	`715`	`Assert(blkno!=GIN_ROOT_BLKNO);`
`716`	`716`	`RecordFreeIndexPage(index,blkno);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit3344451

File tree

1 file changed

1 file changed

`‎src/backend/access/gin/ginvacuum.c`

0 commit comments