Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit3344175

Browse files
committed
Archive timeline history files in standby if archive_mode is set to "always".
Previously the standby server didn't archive timeline history filesstreamed from the primary even when archive_mode is set to "always",while it archives the streamed WAL files. This could cause the PITR tofail because there was no required timeline history file in the archive.The cause of this issue was that walreceiver didn't mark those files asready for archiving.This commit makes walreceiver mark those streamed timeline historyfiles as ready for archiving if archive_mode=always. Then the archiverprocess archives the marked timeline history files.Back-patch to all supported versions.Reported-by: Grigory SmolkinAuthor: Grigory Smolkin, Fujii MasaoReviewed-by: David Zhang, Anastasia LubennikovaDiscussion:https://postgr.es/m/54b059d4-2b48-13a4-6f43-95a087c92367@postgrespro.ru
1 parentde6725d commit3344175

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

‎doc/src/sgml/high-availability.sgml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1383,7 +1383,8 @@ synchronous_standby_names = 'ANY 2 (s1, s2, s3)'
13831383
If <varname>archive_mode</varname> is set to <literal>on</>, the
13841384
archiver is not enabled during recovery or standby mode. If the standby
13851385
server is promoted, it will start archiving after the promotion, but
1386-
will not archive any WAL it did not generate itself. To get a complete
1386+
will not archive any WAL or timeline history files that
1387+
it did not generate itself. To get a complete
13871388
series of WAL files in the archive, you must ensure that all WAL is
13881389
archived, before it reaches the standby. This is inherently true with
13891390
file-based log shipping, as the standby can only restore files that

‎src/backend/replication/walreceiver.c

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -733,6 +733,15 @@ WalRcvFetchTimeLineHistoryFiles(TimeLineID first, TimeLineID last)
733733
*/
734734
writeTimeLineHistoryFile(tli,content,len);
735735

736+
/*
737+
* Mark the streamed history file as ready for archiving
738+
* if archive_mode is always.
739+
*/
740+
if (XLogArchiveMode!=ARCHIVE_MODE_ALWAYS)
741+
XLogArchiveForceDone(fname);
742+
else
743+
XLogArchiveNotify(fname);
744+
736745
pfree(fname);
737746
pfree(content);
738747
}

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp