Commit332584d

committed

Fix EXTRACT(ISOYEAR FROM timestamp) for years BC.

The test cases added by commit26ae3aa exposed an old oversight intimestamp[tz]_part: they didn't correct the result of date2isoyear()for BC years, so that we produced an off-by-one answer for such years.Fix that, and back-patch to all supported branches.Discussion:https://postgr.es/m/SG2PR06MB37762CAE45DB0F6CA7001EA9B6550@SG2PR06MB3776.apcprd06.prod.outlook.com

1 parent7d23381 commit332584dCopy full SHA for 332584d

File tree

-2

lines changed

-2

lines changed

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -4265,6 +4265,7 @@ date2isoweek(int year, int mon, int mday)`
`4265`	`4265`	`/* date2isoyear()`
`4266`	`4266`	`*`
`4267`	`4267`	`*Returns ISO 8601 year number.`
	`4268`	`+ *Note: zero or negative results follow the year-zero-exists convention.`
`4268`	`4269`	`*/`
`4269`	`4270`	`int`
`4270`	`4271`	`date2isoyear(intyear,intmon,intmday)`
`@@ -4539,6 +4540,9 @@ timestamp_part(PG_FUNCTION_ARGS)`
`4539`	`4540`
`4540`	`4541`	`caseDTK_ISOYEAR:`
`4541`	`4542`	`result=date2isoyear(tm->tm_year,tm->tm_mon,tm->tm_mday);`
	`4543`	`+/* Adjust BC years */`
	`4544`	`+if (result <=0)`
	`4545`	`+result-=1;`
`4542`	`4546`	`break;`
`4543`	`4547`
`4544`	`4548`	`caseDTK_DOW:`
`@@ -4735,6 +4739,9 @@ timestamptz_part(PG_FUNCTION_ARGS)`
`4735`	`4739`
`4736`	`4740`	`caseDTK_ISOYEAR:`
`4737`	`4741`	`result=date2isoyear(tm->tm_year,tm->tm_mon,tm->tm_mday);`
	`4742`	`+/* Adjust BC years */`
	`4743`	`+if (result <=0)`
	`4744`	`+result-=1;`
`4738`	`4745`	`break;`
`4739`	`4746`
`4740`	`4747`	`caseDTK_DOW:`

Lines changed: 1 addition & 1 deletion

Lines changed: 1 addition & 1 deletion

Comments

(0)