NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit32ac7a1

committed

Exclude VACUUMs from RunningXactData

GetRunningTransactionData() should ignore VACUUM procs because in somecases they are assigned xids. This could lead to holding back xmin viathe route of passing the xid to standby and then having that hold backxmin on master via feedback.Backpatch to 9.1 needed, but will only do so on supported versions.Backpatch once proven on the buildfarm.Reported-by: Greg StarkAuthor: Simon RiggsReviewed-by: Amit KapilaDiscussion:https://postgr.es/m/CANP8+jJBYt=4PpTfiPb0UrH1_iPhzsxKH5Op_Wec634F0ohnAw@mail.gmail.com

1 parent848b1f3 commit32ac7a1Copy full SHA for 32ac7a1

File tree

1 file changed

-1

lines changed

src/backend/storage/ipc
- procarray.c

1 file changed

-1

lines changed

`‎src/backend/storage/ipc/procarray.c‎`

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1907,7 +1907,7 @@ ProcArrayInstallRestoredXmin(TransactionId xmin, PGPROC *proc)`
`1907`	`1907`	`* GetRunningTransactionData -- returns information about running transactions.`
`1908`	`1908`	`*`
`1909`	`1909`	`* Similar to GetSnapshotData but returns more information. We include`
`1910`		`- * all PGXACTs with an assigned TransactionId,even VACUUM processes.`
	`1910`	`+ * all PGXACTs with an assigned TransactionId,but not VACUUM processes.`
`1911`	`1911`	`*`
`1912`	`1912`	`* We acquire XidGenLock and ProcArrayLock, but the caller is responsible for`
`1913`	`1913`	`* releasing them. Acquiring XidGenLock ensures that no new XIDs enter the proc`
`@@ -1995,6 +1995,10 @@ GetRunningTransactionData(void)`
`1995`	`1995`	`volatilePGXACT*pgxact=&allPgXact[pgprocno];`
`1996`	`1996`	`TransactionIdxid;`
`1997`	`1997`
	`1998`	`+/* Ignore procs running LAZY VACUUM */`
	`1999`	`+if (pgxact->vacuumFlags&PROC_IN_VACUUM)`
	`2000`	`+continue;`
	`2001`	`+`
`1998`	`2002`	`/* Fetch xid just once - see GetNewTransactionId */`
`1999`	`2003`	`xid=pgxact->xid;`
`2000`	`2004`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit32ac7a1

File tree

1 file changed

1 file changed

`‎src/backend/storage/ipc/procarray.c‎`

0 commit comments