NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit324435e

committed

Prevent compilation of frontend-only files in src/common/ with backend

Any frontend-only file of src/common/ should include a protection toprevent such code to be included in the backend compilation.fe_memutils.c and restricted_token.c have been doing that, whilefile_utils.c (sincebf5bb2e) and logging.c (sincefc9a62a) forgot it.Reviewed-by: Daniel GustafssonDiscussion:https://postgr.es/m/20200625080757.GI130132@paquier.xyz

1 parentee0202d commit324435eCopy full SHA for 324435e

File tree

2 files changed

+10

-0

lines changed

src/common
- file_utils.c
- logging.c

2 files changed

+10

-0

lines changed

`‎src/common/file_utils.c`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,11 @@`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
	`15`	`+`
	`16`	`+#ifndefFRONTEND`
	`17`	`+#error "This file is not expected to be compiled for backend code"`
	`18`	`+#endif`
	`19`	`+`
`15`	`20`	`#include"postgres_fe.h"`
`16`	`21`
`17`	`22`	`#include<dirent.h>`

`‎src/common/logging.c`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,11 @@`
`7`	`7`	`*`
`8`	`8`	`*-------------------------------------------------------------------------`
`9`	`9`	`*/`
	`10`	`+`
	`11`	`+#ifndefFRONTEND`
	`12`	`+#error "This file is not expected to be compiled for backend code"`
	`13`	`+#endif`
	`14`	`+`
`10`	`15`	`#include"postgres_fe.h"`
`11`	`16`
`12`	`17`	`#include<unistd.h>`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit324435e

File tree

2 files changed

2 files changed

`‎src/common/file_utils.c`

`‎src/common/logging.c`

0 commit comments