NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit3235a11

committed

Avoid "unused variable" warning on non-USE_SSL_ENGINE platforms.

If we are building with openssl but USE_SSL_ENGINE didn't get set,initialize_SSL's variable "pkey" is declared but used nowhere.Apparently this combination hasn't been exercised in the buildfarmbefore now, because I've not seen this warning before, even thoughthe code has been like this a long time. Move the declarationto silence the warning (and remove its useless initialization).Per buildfarm member sawshark. Back-patch to all supported branches.

1 parent14e4e8f commit3235a11Copy full SHA for 3235a11

File tree

1 file changed

-1

lines changed

src/interfaces/libpq
- fe-secure-openssl.c

1 file changed

-1

lines changed

`‎src/interfaces/libpq/fe-secure-openssl.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -915,7 +915,6 @@ initialize_SSL(PGconn *conn)`
`915`	`915`	`boolhave_homedir;`
`916`	`916`	`boolhave_cert;`
`917`	`917`	`boolhave_rootcert;`
`918`		`-EVP_PKEY*pkey=NULL;`
`919`	`918`
`920`	`919`	`/*`
`921`	`920`	`* We'll need the home directory if any of the relevant parameters are`
`@@ -1265,6 +1264,7 @@ initialize_SSL(PGconn *conn)`
`1265`	`1264`	`/* Colon, but not in second character, treat as engine:key */`
`1266`	`1265`	`char*engine_str=strdup(conn->sslkey);`
`1267`	`1266`	`char*engine_colon;`
	`1267`	`+EVP_PKEY*pkey;`
`1268`	`1268`
`1269`	`1269`	`if (engine_str==NULL)`
`1270`	`1270`	`{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit3235a11

File tree

1 file changed

1 file changed

`‎src/interfaces/libpq/fe-secure-openssl.c`

0 commit comments