NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit31c389d

Amit Kapila

committed

Optimize fileset usage in apply worker.

Use one fileset for the entire worker lifetime instead of usingseparate filesets for each streaming transaction. Now, thechanges/subxacts files for every streaming transaction will becreated under the same fileset and the files will be deletedafter the transaction is completed.This patch extends the BufFileOpenFileSet and BufFileDeleteFileSetAPIs to allow users to specify whether to give an error on missingfiles.Author: Dilip Kumar, based on suggestion by Thomas MunroReviewed-by: Hou Zhijie, Masahiko Sawada, Amit KapilaDiscussion:https://postgr.es/m/E1mCC6U-0004Ik-Fs@gemulon.postgresql.org

1 parent163074e commit31c389dCopy full SHA for 31c389d

File tree

7 files changed

+86

-219

lines changed

src
- backend
  - replication/logical
    - launcher.c
    - worker.c
  - storage/file
    - buffile.c
  - utils/sort
    - logtape.c
    - sharedtuplestore.c
- include
  - replication
    - worker_internal.h
  - storage
    - buffile.h

7 files changed

+86

-219

lines changed

`‎src/backend/replication/logical/launcher.c`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -379,6 +379,7 @@ logicalrep_worker_launch(Oid dbid, Oid subid, const char *subname, Oid userid,`
`379`	`379`	`worker->relid=relid;`
`380`	`380`	`worker->relstate=SUBREL_STATE_UNKNOWN;`
`381`	`381`	`worker->relstate_lsn=InvalidXLogRecPtr;`
	`382`	`+worker->stream_fileset=NULL;`
`382`	`383`	`worker->last_lsn=InvalidXLogRecPtr;`
`383`	`384`	`TIMESTAMP_NOBEGIN(worker->last_send_time);`
`384`	`385`	`TIMESTAMP_NOBEGIN(worker->last_recv_time);`
`@@ -648,8 +649,9 @@ logicalrep_worker_onexit(int code, Datum arg)`
`648`	`649`
`649`	`650`	`logicalrep_worker_detach();`
`650`	`651`
`651`		`-/* Cleanup filesets used for streaming transactions. */`
`652`		`-logicalrep_worker_cleanupfileset();`
	`652`	`+/* Cleanup fileset used for streaming transactions. */`
	`653`	`+if (MyLogicalRepWorker->stream_fileset!=NULL)`
	`654`	`+FileSetDeleteAll(MyLogicalRepWorker->stream_fileset);`
`653`	`655`
`654`	`656`	`ApplyLauncherWakeup();`
`655`	`657`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit31c389d

File tree

7 files changed

7 files changed

`‎src/backend/replication/logical/launcher.c`

0 commit comments