NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit31a925c

committed

From: Peter T Mount <patches@maidast.demon.co.uk>

Ok, this fixes three things:1. It seems (from tests submitted by two people with JBuilder) that JBuilder expects a responce from ResultSetMetaData.getPrecision() & getScale() when used on non numeric types. This patch makes these methods return 0, instead of throwing an exception.2. Fixes a small bug where getting the postgresql type name returns null.3. Fixes a problem with ResultSet.getObject() where getting it's string value returns null if you case the object as (PGobject), but returns the value if you case it as it's self.

1 parent7eddade commit31a925cCopy full SHA for 31a925c

File tree

3 files changed

-4

lines changed

src/interfaces/jdbc/postgresql

3 files changed

-4

lines changed

`‎src/interfaces/jdbc/postgresql/Field.java`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,8 @@ public int getSQLType() throws SQLException`
`58`	`58`	`if (result.getColumnCount() !=1 \|\|result.getTupleCount() !=1)`
`59`	`59`	`thrownewSQLException("Unexpected return from query for type");`
`60`	`60`	`result.next();`
`61`		`-sql_type =getSQLType(result.getString(1));`
	`61`	`+type_name =result.getString(1);`
	`62`	`+sql_type =getSQLType(type_name);`
`62`	`63`	`result.close();`
`63`	`64`	`}`
`64`	`65`	`returnsql_type;`

`‎src/interfaces/jdbc/postgresql/ResultSetMetaData.java`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -266,7 +266,7 @@ public int getPrecision(int column) throws SQLException`
`266`	`266`	`caseTypes.DOUBLE:`
`267`	`267`	`return16;`
`268`	`268`	`default:`
`269`		`-thrownewSQLException("no precision for non-numeric data types.");`
	`269`	`+return0;`
`270`	`270`	`}`
`271`	`271`	`}`
`272`	`272`
`@@ -295,7 +295,7 @@ public int getScale(int column) throws SQLException`
`295`	`295`	`caseTypes.DOUBLE:`
`296`	`296`	`return16;`
`297`	`297`	`default:`
`298`		`-thrownewSQLException("no scale for non-numeric data types");`
	`298`	`+return0;`
`299`	`299`	`}`
`300`	`300`	`}`
`301`	`301`

`‎src/interfaces/jdbc/postgresql/util/PGobject.java`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -97,6 +97,6 @@ public Object clone()`
`97`	`97`	`*/`
`98`	`98`	`publicStringtoString()`
`99`	`99`	`{`
`100`		`-returnvalue;`
	`100`	`+returngetValue();`
`101`	`101`	`}`
`102`	`102`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit31a925c

File tree

3 files changed

3 files changed

`‎src/interfaces/jdbc/postgresql/Field.java`

`‎src/interfaces/jdbc/postgresql/ResultSetMetaData.java`

`‎src/interfaces/jdbc/postgresql/util/PGobject.java`

0 commit comments