NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit3157cbe

committed

Stabilize recently-added information_schema test queries.

These queries could show unexpected entries if the core system,or concurrently-running test scripts, created any functions thatwould appear in the information_schema views. Restrict themto showing functions belonging to this test's schema, as thefar-older nearby test case does.Per experimentation with conversion of some built-in functionsto SQL-function-body style.

1 parentfae6562 commit3157cbeCopy full SHA for 3157cbe

File tree

2 files changed

+22

-6

lines changed

src/test/regress
- expected
  - create_function_3.out
- sql
  - create_function_3.sql

2 files changed

+22

-6

lines changed

`‎src/test/regress/expected/create_function_3.out`

Lines changed: 11 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -475,26 +475,34 @@ SELECT r0.routine_name, r1.routine_name`
`475`	`475`	`FROM information_schema.routine_routine_usage rru`
`476`	`476`	`JOIN information_schema.routines r0 ON r0.specific_name = rru.specific_name`
`477`	`477`	`JOIN information_schema.routines r1 ON r1.specific_name = rru.routine_name`
	`478`	`+ WHERE r0.routine_schema = 'temp_func_test' AND`
	`479`	`+ r1.routine_schema = 'temp_func_test'`
`478`	`480`	`ORDER BY 1, 2;`
`479`	`481`	`routine_name \| routine_name`
`480`	`482`	`----------------+----------------`
`481`	`483`	`functest_is_4b \| functest_is_4a`
`482`	`484`	`(1 row)`
`483`	`485`
`484`		`-SELECT routine_name, sequence_name FROM information_schema.routine_sequence_usage ORDER BY 1, 2;`
	`486`	`+SELECT routine_name, sequence_name FROM information_schema.routine_sequence_usage`
	`487`	`+ WHERE routine_schema = 'temp_func_test'`
	`488`	`+ ORDER BY 1, 2;`
`485`	`489`	`routine_name \| sequence_name`
`486`	`490`	`---------------+---------------`
`487`	`491`	`functest_is_5 \| functest1`
`488`	`492`	`functest_is_6 \| functest1`
`489`	`493`	`(2 rows)`
`490`	`494`
`491`		`-SELECT routine_name, table_name, column_name FROM information_schema.routine_column_usage ORDER BY 1, 2;`
	`495`	`+SELECT routine_name, table_name, column_name FROM information_schema.routine_column_usage`
	`496`	`+ WHERE routine_schema = 'temp_func_test'`
	`497`	`+ ORDER BY 1, 2;`
`492`	`498`	`routine_name \| table_name \| column_name`
`493`	`499`	`---------------+------------+-------------`
`494`	`500`	`functest_is_7 \| functest2 \| a`
`495`	`501`	`(1 row)`
`496`	`502`
`497`		`-SELECT routine_name, table_name FROM information_schema.routine_table_usage ORDER BY 1, 2;`
	`503`	`+SELECT routine_name, table_name FROM information_schema.routine_table_usage`
	`504`	`+ WHERE routine_schema = 'temp_func_test'`
	`505`	`+ ORDER BY 1, 2;`
`498`	`506`	`routine_name \| table_name`
`499`	`507`	`---------------+------------`
`500`	`508`	`functest_is_7 \| functest2`

`‎src/test/regress/sql/create_function_3.sql`

Lines changed: 11 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -277,10 +277,18 @@ SELECT r0.routine_name, r1.routine_name`
`277`	`277`	`FROMinformation_schema.routine_routine_usage rru`
`278`	`278`	`JOINinformation_schema.routines r0ONr0.specific_name=rru.specific_name`
`279`	`279`	`JOINinformation_schema.routines r1ONr1.specific_name=rru.routine_name`
	`280`	`+WHEREr0.routine_schema='temp_func_test'AND`
	`281`	`+r1.routine_schema='temp_func_test'`
	`282`	`+ORDER BY1,2;`
	`283`	`+SELECT routine_name, sequence_nameFROMinformation_schema.routine_sequence_usage`
	`284`	`+WHERE routine_schema='temp_func_test'`
	`285`	`+ORDER BY1,2;`
	`286`	`+SELECT routine_name, table_name, column_nameFROMinformation_schema.routine_column_usage`
	`287`	`+WHERE routine_schema='temp_func_test'`
	`288`	`+ORDER BY1,2;`
	`289`	`+SELECT routine_name, table_nameFROMinformation_schema.routine_table_usage`
	`290`	`+WHERE routine_schema='temp_func_test'`
`280`	`291`	`ORDER BY1,2;`
`281`		`-SELECT routine_name, sequence_nameFROMinformation_schema.routine_sequence_usageORDER BY1,2;`
`282`		`-SELECT routine_name, table_name, column_nameFROMinformation_schema.routine_column_usageORDER BY1,2;`
`283`		`-SELECT routine_name, table_nameFROMinformation_schema.routine_table_usageORDER BY1,2;`
`284`	`292`
`285`	`293`	`DROPFUNCTION functest_IS_4a CASCADE;`
`286`	`294`	`DROPSEQUENCE functest1 CASCADE;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit3157cbe

File tree

2 files changed

2 files changed

`‎src/test/regress/expected/create_function_3.out`

`‎src/test/regress/sql/create_function_3.sql`

0 commit comments