Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit315772e

Browse files
committed
Assert that strong-lock count is >0 everywhere it's decremented.
The one existing assertion of this type has tripped a few times in thebuildfarm lately, but it's not clear whether the problem is reallyoriginating there or whether it's leftovers from a trip through oneof the other two paths that lack a matching assertion. So add one.Since the same bug(s) most likely exist(s) in the back-branches also,back-patch to 9.2, where the fast-path lock mechanism was added.
1 parentb8a7211 commit315772e

File tree

1 file changed

+2
-0
lines changed
  • src/backend/storage/lmgr

1 file changed

+2
-0
lines changed

‎src/backend/storage/lmgr/lock.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1541,6 +1541,7 @@ AbortStrongLockAcquire(void)
15411541
fasthashcode=FastPathStrongLockHashPartition(locallock->hashcode);
15421542
Assert(locallock->holdsStrongLockCount== TRUE);
15431543
SpinLockAcquire(&FastPathStrongRelationLocks->mutex);
1544+
Assert(FastPathStrongRelationLocks->count[fasthashcode]>0);
15441545
FastPathStrongRelationLocks->count[fasthashcode]--;
15451546
locallock->holdsStrongLockCount= FALSE;
15461547
StrongLockInProgress=NULL;
@@ -2953,6 +2954,7 @@ LockRefindAndRelease(LockMethod lockMethodTable, PGPROC *proc,
29532954
uint32fasthashcode=FastPathStrongLockHashPartition(hashcode);
29542955

29552956
SpinLockAcquire(&FastPathStrongRelationLocks->mutex);
2957+
Assert(FastPathStrongRelationLocks->count[fasthashcode]>0);
29562958
FastPathStrongRelationLocks->count[fasthashcode]--;
29572959
SpinLockRelease(&FastPathStrongRelationLocks->mutex);
29582960
}

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp