Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit30f912a

Browse files
committed
Don't add bailout adjustment for non-strict deserialize calls.
When building aggregate expression steps, strict checks need a bailoutjump for when a null value is encountered, so there is a list of stepsthat require later adjustment. Adding entries to that list for stepsthat aren't actually strict would be harmless, except that there is anAssert which catches them. This leads to spurious errors on assertsbuilds, for data sets that trigger parallel aggregation of anaggregate with a non-strict deserialization function (no suchaggregates exist in the core system).Repair by not adding the adjustment entry when it's not needed.Backpatch back to 11 where the code was introduced.Per a report from Darafei (Komzpa) of the PostGIS project; analysisand patch by me.Discussion:https://postgr.es/m/87mty7peb3.fsf@news-spur.riddles.org.uk
1 parentd43e235 commit30f912a

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

‎src/backend/executor/execExpr.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3046,8 +3046,10 @@ ExecBuildAggTrans(AggState *aggstate, AggStatePerPhase phase,
30463046
scratch.resnull=&trans_fcinfo->args[argno+1].isnull;
30473047

30483048
ExprEvalPushStep(state,&scratch);
3049-
adjust_bailout=lappend_int(adjust_bailout,
3050-
state->steps_len-1);
3049+
/* don't add an adjustment unless the function is strict */
3050+
if (pertrans->deserialfn.fn_strict)
3051+
adjust_bailout=lappend_int(adjust_bailout,
3052+
state->steps_len-1);
30513053

30523054
/* restore normal settings of scratch fields */
30533055
scratch.resvalue=&state->resvalue;

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp