Commit30d4772

committed

Fix comments in execGrouping.c

Commit5dfc198 missed updating some comments.Also, fix a comment typo found in passing.Author: Jeff DavisDiscussion:https://postgr.es/m/9723131d247b919f94699152647fa87ee0bc02c2.camel%40j-davis.com

1 parentfbbf680 commit30d4772Copy full SHA for 30d4772

File tree

-9

lines changed

-9

lines changed

Lines changed: 3 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -382,12 +382,9 @@ FindTupleHashEntry(TupleHashTable hashtable, TupleTableSlot *slot,`
`382`	`382`	`/*`
`383`	`383`	`* Compute the hash value for a tuple`
`384`	`384`	`*`
`385`		`- * The passed-in key is a pointer to TupleHashEntryData. In an actual hash`
`386`		`- * table entry, the firstTuple field points to a tuple (in MinimalTuple`
`387`		`- * format). LookupTupleHashEntry sets up a dummy TupleHashEntryData with a`
`388`		`- * NULL firstTuple field --- that cues us to look at the inputslot instead.`
`389`		`- * This convention avoids the need to materialize virtual input tuples unless`
`390`		`- * they actually need to get copied into the table.`
	`385`	`+ * If tuple is NULL, use the input slot instead. This convention avoids the`
	`386`	`+ * need to materialize virtual input tuples unless they actually need to get`
	`387`	`+ * copied into the table.`
`391`	`388`	`*`
`392`	`389`	`* Also, the caller must select an appropriate memory context for running`
`393`	`390`	`* the hash functions. (dynahash.c doesn't change CurrentMemoryContext.)`
`@@ -455,8 +452,6 @@ TupleHashTableHash(struct tuplehash_hash *tb, const MinimalTuple tuple)`
`455`	`452`
`456`	`453`	`/*`
`457`	`454`	`* See whether two tuples (presumably of the same hash value) match`
`458`		`- *`
`459`		`- * As above, the passed pointers are pointers to TupleHashEntryData.`
`460`	`455`	`*/`
`461`	`456`	`staticint`
`462`	`457`	`TupleHashTableMatch(structtuplehash_hash*tb,constMinimalTupletuple1,constMinimalTupletuple2)`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2248,7 +2248,7 @@ typedef struct HashInstrumentation`
`2248`	`2248`	`intnbuckets_original;/* planned number of buckets */`
`2249`	`2249`	`intnbatch;/* number of batches at end of execution */`
`2250`	`2250`	`intnbatch_original;/* planned number of batches */`
`2251`		`-size_tspace_peak;/speak memory usage in bytes /`
	`2251`	`+size_tspace_peak;/peak memory usage in bytes /`
`2252`	`2252`	`}HashInstrumentation;`
`2253`	`2253`
`2254`	`2254`	`/* ----------------`

Comments

(0)