NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit308d4ec

committed

Fix inappropriate error messages for Hot Standby misconfiguration errors.

Give the correct name of the GUC parameter being complained of.Also, emit a more suitable SQLSTATE (INVALID_PARAMETER_VALUE,not the default INTERNAL_ERROR).Gurjeet Singh, errcode adjustment by me

1 parent8a66a37 commit308d4ecCopy full SHA for 308d4ec

File tree

1 file changed

-4

lines changed

src/backend/access/transam
- xlog.c

1 file changed

-4

lines changed

`‎src/backend/access/transam/xlog.c`

Lines changed: 5 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -5990,9 +5990,10 @@ GetXLogReceiptTime(TimestampTz rtime, bool fromStream)`
`5990`	`5990`	`*/`
`5991`	`5991`	`#defineRecoveryRequiresIntParameter(param_name,currValue,minValue) \`
`5992`	`5992`	`do { \`
`5993`		`-if (currValue < minValue) \`
	`5993`	`+if ((currValue) <(minValue)) \`
`5994`	`5994`	`ereport(ERROR, \`
`5995`		`-(errmsg("hot standby is not possible because " \`
	`5995`	`+(errcode(ERRCODE_INVALID_PARAMETER_VALUE), \`
	`5996`	`+ errmsg("hot standby is not possible because " \`
`5996`	`5997`	`"%s = %d is a lower setting than on the master server " \`
`5997`	`5998`	`"(its value was %d)", \`
`5998`	`5999`	`param_name, \`
`@@ -6033,10 +6034,10 @@ CheckRequiredParameterValues(void)`
`6033`	`6034`	`RecoveryRequiresIntParameter("max_connections",`
`6034`	`6035`	`MaxConnections,`
`6035`	`6036`	`ControlFile->MaxConnections);`
`6036`		`-RecoveryRequiresIntParameter("max_prepared_xacts",`
	`6037`	`+RecoveryRequiresIntParameter("max_prepared_transactions",`
`6037`	`6038`	`max_prepared_xacts,`
`6038`	`6039`	`ControlFile->max_prepared_xacts);`
`6039`		`-RecoveryRequiresIntParameter("max_locks_per_xact",`
	`6040`	`+RecoveryRequiresIntParameter("max_locks_per_transaction",`
`6040`	`6041`	`max_locks_per_xact,`
`6041`	`6042`	`ControlFile->max_locks_per_xact);`
`6042`	`6043`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit308d4ec

File tree

1 file changed

1 file changed

`‎src/backend/access/transam/xlog.c`

0 commit comments