NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit306d6e5

committed

Fix broken extract_actual_join_clauses call in 9.6 postgres_fdw.

In commitse5d8399 et al, I changed the signature ofextract_actual_join_clauses, thinking that it was not called fromanywhere but createplan.c. I missed that postgres_fdw uses itin the 9.6 branch only.This opens up the question of whether any third-party modules mightbe calling it, and whether we need to take steps to avoid an API breakfor them. But for the moment, just get the buildfarm green again.

1 parent0c141fc commit306d6e5Copy full SHA for 306d6e5

File tree

1 file changed

-1

lines changed

contrib/postgres_fdw
- postgres_fdw.c

1 file changed

-1

lines changed

`‎contrib/postgres_fdw/postgres_fdw.c`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3976,7 +3976,9 @@ foreign_join_ok(PlannerInfo root, RelOptInfo joinrel, JoinType jointype,`
`3976`	`3976`
`3977`	`3977`	`/* Separate restrict list into join quals and quals on join relation */`
`3978`	`3978`	`if (IS_OUTER_JOIN(jointype))`
`3979`		`-extract_actual_join_clauses(extra->restrictlist,&joinclauses,&otherclauses);`
	`3979`	`+extract_actual_join_clauses(extra->restrictlist,`
	`3980`	`+joinrel->relids,`
	`3981`	`+&joinclauses,&otherclauses);`
`3980`	`3982`	`else`
`3981`	`3983`	`{`
`3982`	`3984`	`/*`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit306d6e5

File tree

1 file changed

1 file changed

`‎contrib/postgres_fdw/postgres_fdw.c`

0 commit comments