Commit3026493

committed

This patch fixes two tiny memory leaks in pg_dump and two in pg_dumpall.

Neil Conway

1 parentcf4e603 commit3026493Copy full SHA for 3026493

File tree

-3

lines changed

-3

lines changed

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@`
`12`	`12`	`*by PostgreSQL`
`13`	`13`	`*`
`14`	`14`	`* IDENTIFICATION`
`15`		`- * $Header: /cvsroot/pgsql/src/bin/pg_dump/pg_dump.c,v 1.308 2002/11/23 03:59:08 momjian Exp $`
	`15`	`+ * $Header: /cvsroot/pgsql/src/bin/pg_dump/pg_dump.c,v 1.309 2002/11/29 16:38:42 momjian Exp $`
`16`	`16`	`*`
`17`	`17`	`*-------------------------------------------------------------------------`
`18`	`18`	`*/`
`@@ -3226,6 +3226,7 @@ dumpOneDomain(Archive fout, TypeInfo tinfo)`
`3226`	`3226`	`"WHERE contypid = '%s'::pg_catalog.oid",`
`3227`	`3227`	`tinfo->oid);`
`3228`	`3228`
	`3229`	`+PQclear(res);`
`3229`	`3230`	`res=PQexec(g_conn,chkquery->data);`
`3230`	`3231`	`if (!res\|\|`
`3231`	`3232`	`PQresultStatus(res)!=PGRES_TUPLES_OK)`
`@@ -3269,6 +3270,7 @@ dumpOneDomain(Archive fout, TypeInfo tinfo)`
`3269`	`3270`	`destroyPQExpBuffer(q);`
`3270`	`3271`	`destroyPQExpBuffer(delq);`
`3271`	`3272`	`destroyPQExpBuffer(query);`
	`3273`	`+destroyPQExpBuffer(chkquery);`
`3272`	`3274`	`}`
`3273`	`3275`
`3274`	`3276`	`/*`

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`	`* Portions Copyright (c) 1994, Regents of the University of California`
`7`	`7`	`*`
`8`	`8`	`*`
`9`		`- * $Header: /cvsroot/pgsql/src/bin/pg_dump/pg_dumpall.c,v 1.10 2002/11/22 03:09:43 tgl Exp $`
	`9`	`+ * $Header: /cvsroot/pgsql/src/bin/pg_dump/pg_dumpall.c,v 1.11 2002/11/29 16:38:42 momjian Exp $`
`10`	`10`	`*`
`11`	`11`	`*-------------------------------------------------------------------------`
`12`	`12`	`*/`
`@@ -403,7 +403,7 @@ dumpCreateDB(PGconn *conn)`
`403`	`403`
`404`	`404`	`for (i=0;i<PQntuples(res);i++)`
`405`	`405`	`{`
`406`		`-PQExpBufferbuf=createPQExpBuffer();`
	`406`	`+PQExpBufferbuf;`
`407`	`407`	`char*dbname=PQgetvalue(res,i,0);`
`408`	`408`	`char*dbowner=PQgetvalue(res,i,1);`
`409`	`409`	`char*dbencoding=PQgetvalue(res,i,2);`
`@@ -413,6 +413,8 @@ dumpCreateDB(PGconn *conn)`
`413`	`413`	`if (strcmp(dbname,"template1")==0)`
`414`	`414`	`continue;`
`415`	`415`
	`416`	`+buf=createPQExpBuffer();`
	`417`	`+`
`416`	`418`	`if (output_clean)`
`417`	`419`	`appendPQExpBuffer(buf,"DROP DATABASE %s\n;",fmtId(dbname));`
`418`	`420`
`@@ -692,6 +694,7 @@ connectDatabase(const char dbname, const char pghost, const char *pgport,`
`692`	`694`	`exit(1);`
`693`	`695`	`}`
`694`	`696`	`}`
	`697`	`+PQclear(res);`
`695`	`698`
`696`	`699`	`returnconn;`
`697`	`700`	`}`

Comments

(0)