NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit302612a

committed

Silence minor compiler warnings.

Depending on compiler version and optimization level, we mightget a complaint that lazy_scan_heap's "freespace" is useduninitialized.Compilers not aware that ereport(ERROR) doesn't return complainedabout bbsink_lz4_new().Assigning "-1" to a uint64 value has unportable results; fortunately,the value of xlogreadsegno is unimportant when xlogreadfd is -1.(It looks to me like there is no need for xlogreadsegno to be staticin the first place, but I didn't venture to change that.)

1 parentf79c94f commit302612aCopy full SHA for 302612a

File tree

3 files changed

-2

lines changed

src
- backend
  - access/heap
    - vacuumlazy.c
  - replication
    - basebackup_lz4.c
- bin/pg_rewind
  - parsexlog.c

3 files changed

-2

lines changed

`‎src/backend/access/heap/vacuumlazy.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1112,7 +1112,7 @@ lazy_scan_heap(LVRelState *vacrel, int nworkers)`
`1112`	`1112`	`if (lazy_scan_noprune(vacrel,buf,blkno,page,&hastup,`
`1113`	`1113`	`&recordfreespace))`
`1114`	`1114`	`{`
`1115`		`-Sizefreespace;`
	`1115`	`+Sizefreespace=0;`
`1116`	`1116`
`1117`	`1117`	`/*`
`1118`	`1118`	`* Processed page successfully (without cleanup lock) -- just`

`‎src/backend/replication/basebackup_lz4.c`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -66,6 +66,7 @@ bbsink_lz4_new(bbsink *next, int compresslevel)`
`66`	`66`	`ereport(ERROR,`
`67`	`67`	`(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),`
`68`	`68`	`errmsg("lz4 compression is not supported by this build")));`
	`69`	`+returnNULL;/* keep compiler quiet */`
`69`	`70`	`#else`
`70`	`71`	`bbsink_lz4*sink;`
`71`	`72`

`‎src/bin/pg_rewind/parsexlog.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ static const char *RmgrNames[RM_MAX_ID + 1] = {`
`38`	`38`	`staticvoidextractPageInfo(XLogReaderState*record);`
`39`	`39`
`40`	`40`	`staticintxlogreadfd=-1;`
`41`		`-staticXLogSegNoxlogreadsegno=-1;`
	`41`	`+staticXLogSegNoxlogreadsegno=0;`
`42`	`42`	`staticcharxlogfpath[MAXPGPATH];`
`43`	`43`
`44`	`44`	`typedefstructXLogPageReadPrivate`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit302612a

File tree

3 files changed

3 files changed

`‎src/backend/access/heap/vacuumlazy.c`

`‎src/backend/replication/basebackup_lz4.c`

`‎src/bin/pg_rewind/parsexlog.c`

0 commit comments