NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit2fcf685

committed

Fix come incorrect elog() messages in aclchk.c

Three error strings used with cache lookup failures were referring toincorrect object types for ACL checks:- Schemas- Types- Foreign ServersThere errors should never be triggered, but if they do incorrectinformation would be reported.Author: Justin PryzbyDiscussion:https://postgr.es/m/20221222153041.GN1153@telsasoft.comBackpatch-through: 11

1 parent13e0d7a commit2fcf685Copy full SHA for 2fcf685

File tree

1 file changed

-3

lines changed

src/backend/catalog
- aclchk.c

1 file changed

-3

lines changed

`‎src/backend/catalog/aclchk.c`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -4369,7 +4369,7 @@ recordExtObjInitPriv(Oid objoid, Oid classoid)`
`4369`	`4369`
`4370`	`4370`	`tuple=SearchSysCache1(FOREIGNSERVEROID,ObjectIdGetDatum(objoid));`
`4371`	`4371`	`if (!HeapTupleIsValid(tuple))`
`4372`		`-elog(ERROR,"cache lookup failed for foreigndata wrapper %u",`
	`4372`	`+elog(ERROR,"cache lookup failed for foreignserver %u",`
`4373`	`4373`	`objoid);`
`4374`	`4374`
`4375`	`4375`	`aclDatum=SysCacheGetAttr(FOREIGNSERVEROID,tuple,`
`@@ -4455,7 +4455,7 @@ recordExtObjInitPriv(Oid objoid, Oid classoid)`
`4455`	`4455`
`4456`	`4456`	`tuple=SearchSysCache1(NAMESPACEOID,ObjectIdGetDatum(objoid));`
`4457`	`4457`	`if (!HeapTupleIsValid(tuple))`
`4458`		`-elog(ERROR,"cache lookup failed forfunction %u",objoid);`
	`4458`	`+elog(ERROR,"cache lookup failed forschema %u",objoid);`
`4459`	`4459`
`4460`	`4460`	`aclDatum=SysCacheGetAttr(NAMESPACEOID,tuple,`
`4461`	`4461`	`Anum_pg_namespace_nspacl,&isNull);`
`@@ -4497,7 +4497,7 @@ recordExtObjInitPriv(Oid objoid, Oid classoid)`
`4497`	`4497`
`4498`	`4498`	`tuple=SearchSysCache1(TYPEOID,ObjectIdGetDatum(objoid));`
`4499`	`4499`	`if (!HeapTupleIsValid(tuple))`
`4500`		`-elog(ERROR,"cache lookup failed forfunction %u",objoid);`
	`4500`	`+elog(ERROR,"cache lookup failed fortype %u",objoid);`
`4501`	`4501`
`4502`	`4502`	`aclDatum=SysCacheGetAttr(TYPEOID,tuple,Anum_pg_type_typacl,`
`4503`	`4503`	`&isNull);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit2fcf685

File tree

1 file changed

1 file changed

`‎src/backend/catalog/aclchk.c`

0 commit comments