forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit2f5c439
committed
When fetching WAL for a basebackup, report errors with a sensible TLI.
The previous code used ThisTimeLineID, which need not even beinitialized here, although it usually was in practice, becausepg_basebackup issues IDENTIFY_SYSTEM before calling BASE_BACKUP,and that initializes ThisTimeLineID as a side effect. That's notreally good enough, though, not only because we shoudn't be countingon side effects like that, but also because the TLI could changemeanwhile. Fortunately, we have convenient access to more meaningfulTLI values, so use those instead.Because of the way this logic is coded, the consequences of usinga possibly-incorrect TLI here are no worse than a slightly confusingerror message, I don't want to take any risk here, so no back-patchat least for now.Patch by me, reviewed by Kyotaro Horiguchi and Michael PaquierDiscussion:http://postgr.es/m/CA+TgmoZRNWGWYDX9RgTXMG6_nwSdB=PB-PPRUbvMUTGfmL2sHQ@mail.gmail.com1 parent5f55fc5 commit2f5c439
1 file changed
+6
-7
lines changedLines changed: 6 additions & 7 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
502 | 502 |
| |
503 | 503 |
| |
504 | 504 |
| |
505 |
| - | |
| 505 | + | |
506 | 506 |
| |
507 |
| - | |
| 507 | + | |
508 | 508 |
| |
509 | 509 |
| |
510 | 510 |
| |
| |||
528 | 528 |
| |
529 | 529 |
| |
530 | 530 |
| |
531 |
| - | |
| 531 | + | |
532 | 532 |
| |
533 | 533 |
| |
534 | 534 |
| |
| |||
555 | 555 |
| |
556 | 556 |
| |
557 | 557 |
| |
558 |
| - | |
| 558 | + | |
559 | 559 |
| |
560 | 560 |
| |
561 | 561 |
| |
| |||
571 | 571 |
| |
572 | 572 |
| |
573 | 573 |
| |
574 |
| - | |
575 |
| - | |
| 574 | + | |
576 | 575 |
| |
577 | 576 |
| |
578 | 577 |
| |
| |||
581 | 580 |
| |
582 | 581 |
| |
583 | 582 |
| |
584 |
| - | |
| 583 | + | |
585 | 584 |
| |
586 | 585 |
| |
587 | 586 |
| |
|
0 commit comments
Comments
(0)