NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit2f30226

committed

Fix query checking consistency of table amhandlers in opr_sanity.sql

As written, the query checked for an access method of type 's', which isnot an AM type supported in the core code.Error introduced by8586bf7. As this query is not checking what itshould, backpatch all the way down.Reviewed-by: Aleksander AlekseevDiscussion:https://postgr.es/m/ZVxJkAJrKbfHETiy@paquier.xyzBackpatch-through: 12

1 parent3af101c commit2f30226Copy full SHA for 2f30226

File tree

2 files changed

-2

lines changed

src/test/regress
- expected
  - opr_sanity.out
- sql
  - opr_sanity.sql

2 files changed

-2

lines changed

`‎src/test/regress/expected/opr_sanity.out`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1920,7 +1920,7 @@ WHERE p1.oid = a1.amhandler AND a1.amtype = 'i' AND`
`1920`	`1920`	`-- Check for table amhandler functions with the wrong signature`
`1921`	`1921`	`SELECT a1.oid, a1.amname, p1.oid, p1.proname`
`1922`	`1922`	`FROM pg_am AS a1, pg_proc AS p1`
`1923`		`-WHERE p1.oid = a1.amhandler AND a1.amtype = 's' AND`
	`1923`	`+WHERE p1.oid = a1.amhandler AND a1.amtype = 't' AND`
`1924`	`1924`	`(p1.prorettype != 'table_am_handler'::regtype`
`1925`	`1925`	`OR p1.proretset`
`1926`	`1926`	`OR p1.pronargs != 1`

`‎src/test/regress/sql/opr_sanity.sql`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1223,7 +1223,7 @@ WHERE p1.oid = a1.amhandler AND a1.amtype = 'i' AND`
`1223`	`1223`
`1224`	`1224`	`SELECT a1.oid, a1.amname, p1.oid, p1.proname`
`1225`	`1225`	`FROM pg_am AS a1, pg_proc AS p1`
`1226`		`-WHERE p1.oid = a1.amhandler AND a1.amtype = 's' AND`
	`1226`	`+WHERE p1.oid = a1.amhandler AND a1.amtype = 't' AND`
`1227`	`1227`	`(p1.prorettype != 'table_am_handler'::regtype`
`1228`	`1228`	`OR p1.proretset`
`1229`	`1229`	`OR p1.pronargs != 1`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit2f30226

File tree

2 files changed

2 files changed

`‎src/test/regress/expected/opr_sanity.out`

`‎src/test/regress/sql/opr_sanity.sql`

0 commit comments